Change in vdsm[master]: vdsm.spec: vdsm-python requires zombiereaper

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................

vdsm.spec: vdsm-python requires zombiereaper

vdsm/utils.py requires vdsm--python-zombiereaper

Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/23168/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 125344f..9952428 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -340,6 +340,8 @@
 %package python
 Summary:        VDSM python libraries
 
+Requires: %{name}-python-zombiereaper = %{version}-%{release}
+
 %description python
 Shared libraries between the various VDSM packages.
 


-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/240/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6689/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6602/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5796/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/235/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm.spec.in
Line 338: Manager.
Line 339: 
Line 340: %package python
Line 341: Summary:        VDSM python libraries
Line 342: 
debug-plugin below does not have a newline before its first "Requires".
Line 343: Requires: %{name}-python-zombiereaper = %{version}-%{release}
Line 344: 
Line 345: %description python
Line 346: Shared libraries between the various VDSM packages.


-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6701/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6614/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5808/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/239/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


vdsm.spec: vdsm-python requires zombiereaper

vdsm/utils.py requires vdsm--python-zombiereaper

Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/23168
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm.spec.in
Line 338: Manager.
Line 339: 
Line 340: %package python
Line 341: Summary:        VDSM python libraries
Line 342: 
I am ok to change this.. others sub-packages use this style. Dan please let me know which
one you want.
Line 343: Requires: %{name}-python-zombiereaper = %{version}-%{release}
Line 344: 
Line 345: %description python
Line 346: Shared libraries between the various VDSM packages.


-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm.spec.in
Line 338: Manager.
Line 339: 
Line 340: %package python
Line 341: Summary:        VDSM python libraries
Line 342: 
you can omit the empty line above
Line 343: Requires: %{name}-python-zombiereaper = %{version}-%{release}
Line 344: 
Line 345: %description python
Line 346: Shared libraries between the various VDSM packages.


-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: vdsm-python requires zombiereaper
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/23168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc51e4be421f98975c970926c507e226f868a9a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-HasComments: No