From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has uploaded a new change for review.
Change subject: netinfo_test: simplify two asserts ......................................................................
netinfo_test: simplify two asserts
Change-Id: I2c0f1ca8785341cb2ac23470b774fc12318fa555 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/network/netinfo_test.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/69049/1
diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py index 6dfcb98..fbd3328 100644 --- a/tests/network/netinfo_test.py +++ b/tests/network/netinfo_test.py @@ -433,14 +433,14 @@ @ValidateRunningAsRoot def test_local_auto_without_router_advertisement_server(self): with dummy_device() as dev: - self.assertEqual(True, addresses.is_ipv6_local_auto(dev)) + self.assertTrue(addresses.is_ipv6_local_auto(dev))
@ValidateRunningAsRoot def test_local_auto_with_static_address_without_ra_server(self): with dummy_device() as dev: ipwrapper.addrAdd(dev, '2001::88', '64', family=6) ip_addrs = addresses.getIpAddrs()[dev] - self.assertEqual(True, addresses.is_ipv6_local_auto(dev)) + self.assertTrue(addresses.is_ipv6_local_auto(dev)) self.assertEqual(2, len(ip_addrs)) self.assertTrue(addresses.is_ipv6(ip_addrs[0])) self.assertTrue(not addresses.is_dynamic(ip_addrs[0]))
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo_test: simplify two asserts ......................................................................
Patch Set 1: Verified+1
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo_test: simplify three asserts ......................................................................
Patch Set 2: Code-Review+2 Verified+1
tests still pass
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo_test: simplify three asserts ......................................................................
netinfo_test: simplify three asserts
Change-Id: I2c0f1ca8785341cb2ac23470b774fc12318fa555 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/network/netinfo_test.py 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve
vdsm-patches@lists.fedorahosted.org