Mark Wu has uploaded a new change for review.
Change subject: Enable logging facility for test cases ......................................................................
Enable logging facility for test cases
In current code, there's no log handler configured. So make use of the logging configured by nose.config for test cases.
Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M tests/testrunner.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/3712/1 -- To view, visit http://gerrit.ovirt.org/3712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Enable logging facility for test cases ......................................................................
Patch Set 1:
seems reasonable, but could you educate me on how this is going to be used?
-- To view, visit http://gerrit.ovirt.org/3712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Enable logging facility for test cases ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
And we shouldn't redirect to a log file because it will make the lines to appear in the jenkins report
-- To view, visit http://gerrit.ovirt.org/3712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Enable logging facility for test cases ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/100/
-- To view, visit http://gerrit.ovirt.org/3712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Enable logging facility for test cases ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/100/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/3712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Enable logging facility for test cases ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/testrunner.py Line 49: Line 50: class VdsmTestCase(unittest.TestCase): Line 51: def __init__(self, *args, **kwargs): Line 52: unittest.TestCase.__init__(self, *args, **kwargs) Line 53: self.log = logging.getLogger("nose." + self.__class__.__name__) A logging.config.dictConfig() call will do. Line 54: Line 55: Line 56: class VdsmTestResult(result.TextTestResult): Line 57: def __init__(self, *args, **kwargs):
-- To view, visit http://gerrit.ovirt.org/3712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Enable logging facility for test cases ......................................................................
Patch Set 1:
I'm OK with the log message in the console output or in the log file. If it is in the console output, we can see them directly in Jenkins. If it is in the log file, we can edit Jenkins job configuration to let it save that log file for downloading from web.
-- To view, visit http://gerrit.ovirt.org/3712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iaf727a2dfe38206737e0711466978277cd95ad34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has abandoned this change.
Change subject: Enable logging facility for test cases ......................................................................
Patch Set 1: Abandoned
vdsm-patches@lists.fedorahosted.org