Change in vdsm[master]: Don't try to schedule SPM tasks on HSM

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Don't try to schedule SPM tasks on HSM
......................................................................

Don't try to schedule SPM tasks on HSM

Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
---
M vdsm/storage/hsm.py
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/695/1
--
To view, visit http://gerrit.ovirt.org/695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Don't try to schedule SPM tasks on HSM
......................................................................


Don't try to schedule SPM tasks on HSM

When the manager tries to run an SPM task on an HSM host the returned
(and logged) error is not clear:

Traceback (most recent call last):
[...]
  File "/usr/share/vdsm/storage/hsm.py", line 571, in _spmSchedule
    self.taskMng.scheduleJob("spm", pool.tasksDir, vars.task, name,
                             func, *args)
AttributeError: 'StoragePool' object has no attribute 'tasksDir'

VDSM should verify to be an SPM before trying to schedule any spm
job.

Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
---
M vdsm/storage/hsm.py
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Don't try to schedule SPM tasks on HSM
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Don't try to schedule SPM tasks on HSM
......................................................................


Patch Set 2: Looks good to me, approved

Ok, per the following clear-up:

(03:31:41 PM) fsimonce: it obviously is [a logging issue onlu]... it's not a security
measure (not atomic, bla bla...)

--
To view, visit http://gerrit.ovirt.org/695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Ayal Baron has posted comments on this change.

Change subject: Don't try to schedule SPM tasks on HSM
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Don't try to schedule SPM tasks on HSM
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Don't try to schedule SPM tasks on HSM
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Patch seems reasonable, but I lack some context. How come this function got called on an
HSM? Functions leading to this call should be @secured, no?

(I'd appreciate an answer in the commit message)

--
To view, visit http://gerrit.ovirt.org/695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7183fb2a7ef391a73cbb1a6dff9bf46238275100
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;