From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Remove invalid pyc file tests
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/67339/1//COMMIT_MSG
Commit Message:
Line 7: tests: Remove invalid pyc file tests
Line 8:
Line 9: moduleloader test was creating empty (invalid) "a.pyc" file. Existance
Line 10: of an invalid "a.pyc" file may casue the test to fail if
"a.pyc" file is
Line 11: newer then the "a.py". This depends on the resolution of the file
system
we create a.py and a.pyc at the same time in the test flow.. I don't understand if
this scenario is something that you actually see or something that you worry about?
Line 12: timestamps and the timing.
Line 13:
Line 14: Since import of pyc files is not the subject of this test, I removed the
Line 15: pyc file from the test data.
Line 11: newer then the "a.py". This depends on the resolution of the file
system
Line 12: timestamps and the timing.
Line 13:
Line 14: Since import of pyc files is not the subject of this test, I removed the
Line 15: pyc file from the test data.
this is. I want to load the module only once, having pyc and py for the same module name,
with a wrong code, can cause wrong behavior that I prefer to test
Line 16:
Line 17: Change-Id: Iffd6371a5f4ace637ea99d4a91550a277cbf3f72
--
To view, visit
https://gerrit.ovirt.org/67339
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd6371a5f4ace637ea99d4a91550a277cbf3f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes