Federico Simoncelli has posted comments on this change.
Change subject: BZ#732980 Devices block size must be 512
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File vdsm/storage/multipath.py
Line 254: except Exception:
Line 255: log.warn("Problem getting fwrev from device `%s`",
slave, exc_info=True)
Line 256:
Line 257: if not devInfo["logicalblocksize"] or not
devInfo["physicalblocksize"]:
Line 258: try:
Who is not reporting the block size? The kernel? All block devices must report a block
size, if they don't we fail.
Line 259: logBlkSize, phyBlkSize = getDeviceBlockSizes(slave)
Line 260: devInfo["logicalblocksize"] = str(logBlkSize)
Line 261: devInfo["physicalblocksize"] = str(phyBlkSize)
Line 262: except Exception:
--
To view, visit
http://10.35.18.144/855
To unsubscribe, visit
http://10.35.18.144/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>