Change in vdsm[master]: vdsm-reg.conf.in: remove vdc_authkeys_path

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm-reg.conf.in: remove vdc_authkeys_path
......................................................................

vdsm-reg.conf.in: remove vdc_authkeys_path

The auth key is defined in deployUtil.py.in

Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
---
M vdsm_reg/vdsm-reg.conf.in
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/798/1
--
To view, visit http://gerrit.ovirt.org/798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg.conf.in: remove vdc_authkeys_path
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Please explain that the configurable value was never used !

If you remove it from here, you should drop it from config.py as well.

--
To view, visit http://gerrit.ovirt.org/798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg.conf.in: remove vdc_authkeys_path
......................................................................


Patch Set 2: Looks good to me, approved

This conf value has never been used *according to written history*. Legends say that it
was used temporarily 3 years ago.

--
To view, visit http://gerrit.ovirt.org/798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm-reg.conf.in: remove vdc_authkeys_path
......................................................................


vdsm-reg.conf.in: remove vdc_authkeys_path

The auth key is defined in deployUtil.py.in
This conf value has never been used.

Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
---
M vdsm_reg/vdsm-reg.conf.in
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg.conf.in: remove vdc_authkeys_path
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg.conf.in: remove vdc_authkeys_path
......................................................................


Patch Set 1:

Hi Dan,

Yesterday during the quick patch split ( the bridge one) I missed to remove the change
from the config. So, we already have removed this from the config.
http://gerrit.ovirt.org/#patch,sidebyside,311,11,vdsm_reg/config.py

--
To view, visit http://gerrit.ovirt.org/798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg.conf.in: remove vdc_authkeys_path
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ed0cb70d3d77bc00c3dec8cd263968bbd37622e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;