Liron Ar has posted comments on this change.
Change subject: json-rpc: Protocol detection
......................................................................
Patch Set 29:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/29/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 1055: def __init__(self, xml_binding):
Line 1056: self.xml_binding = xml_binding
Line 1057:
Line 1058: def detect(self, data):
Line 1059: return data.startswith("PUT /") or data.startswith("POST /RPC2")
please align this part with http://gerrit.ovirt.org/#/c/26741/
Line 1060:
Line 1061: def handleSocket(self, client_socket, socket_address):
Line 1062: self.xml_binding.add_socket(client_socket, socket_address)
--
To view, visit
http://gerrit.ovirt.org/26300
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Barak Azulay
bazulay@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Liron Ar
laravot@redhat.com
Gerrit-Reviewer: Michal Skrivanek
michal.skrivanek@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra
vfeenstr@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes