Vinzenz Feenstra has posted comments on this change.
Change subject: network: Introduce the network package
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Please fix the copyrights at least in a follow up patch. If there's no new revision
needed here now.
http://gerrit.ovirt.org/#/c/25908/4/vdsm/network/Makefile.am
File vdsm/network/Makefile.am:
Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
Well this should have been 2013-2014 right?
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
http://gerrit.ovirt.org/#/c/25908/4/vdsm/network/configurators/Makefile.am
File vdsm/network/configurators/Makefile.am:
Line 1: # Copyright 20013-2014 Red Hat, Inc.
20013? :-)
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit
http://gerrit.ovirt.org/25908
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes