11:18 a.m.
Igor Lvovsky has uploaded a new change for review.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Fix floppy drives: bus should be 'fdc'.
Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
---
M vdsm/vm.py
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/787/1
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
11:21 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:14 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
I'm confused by the commit message. It explains only one of the changes, keeping 2 odd
ones to my guessing.
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:43 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/vm.py
Line 593: if drive.isVdsmImage() and drive.get('volumeID') ==
d.volumeID:
why was isVdsmImage added?
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
9:22 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/vm.py
Line 593: if drive.isVdsmImage() and drive.get('volumeID') ==
d.volumeID:
_derives contains objects, not dicts, thus .get() would fail.
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
7:20 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
8:32 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
8:32 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Fix floppy drives: bus should be 'fdc'.
Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Igor Lvovsky: Verified
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4503
days inactive
4509
days old
vdsm-patches@lists.fedorahosted.org
7 comments
2 participants
participants (2)
-
Dan Kenigsberg -
Igor Lvovsky