Change in vdsm[master]: check-patch: retire snapshot repo in favor of latest.tested

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: check-patch: retire snapshot repo in favor of latest.tested
......................................................................

check-patch: retire snapshot repo in favor of latest.tested

We should test if a patch builds agains a set of known-good dependcies
("latest.tested"), rather than a random nightly snapshot.

Hopefully, with this patch, check-patch would pass, as ovirt-imageio for
fc25 is to be found in the currently-referred repository.

Change-Id: Ieec022ce45b268442140a35038b3accba9f8733f
Signed-off-by: Dan Kenigsberg 
---
M automation/check-patch.repos.fc25
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/71645/1

diff --git a/automation/check-patch.repos.fc25 b/automation/check-patch.repos.fc25
index 27ae353..37f688c 100644
--- a/automation/check-patch.repos.fc25
+++ b/automation/check-patch.repos.fc25
@@ -1,4 +1,4 @@
-ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro
+latest.tested,http://resources.ovirt.org/repos/ovirt/experimental/master/latest.tested/rpm...
 ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro
 ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro
 lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: check-patch: retire snapshot repo in favor of latest.tested
......................................................................

Patch Set 1: Verified+1

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: check-patch: retire snapshot repo in favor of latest.tested
......................................................................

Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/71645/1//COMMIT_MSG
Commit Message:

PS1, Line 13: fc25
> Why are you changing only fc25 job? Shouldn't we update all jobs?

There's no good reason. I was only trying to unbreak fc25. But you are correct that we should have all distros in sync.

Note that we should stop running fc24 on master; it only eats resources.

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: check-patch: retire snapshot repo in favor of latest.tested
......................................................................

Patch Set 2: Code-Review+1

Change in vdsm[master]: check-patch: retire snapshot repo in favor of 'tested'

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: check-patch: retire snapshot repo in favor of 'tested'
......................................................................

Patch Set 3: Code-Review+2 Verified+1

passes CI, good for me for now.

fc24 and el7 should probably be fixed in a follow-up patch.

Change in vdsm[master]: check-patch: retire snapshot repo in favor of 'tested'

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: check-patch: retire snapshot repo in favor of 'tested'
......................................................................

check-patch: retire snapshot repo in favor of 'tested'

We should test if a patch builds agains a set of known-good dependcies
("tested"), rather than a random nightly snapshot.

Hopefully, with this patch, check-patch would pass, as ovirt-imageio for
fc25 is to be found in the currently-referred repository.

Change-Id: Ieec022ce45b268442140a35038b3accba9f8733f
Signed-off-by: Dan Kenigsberg 
Signed-off-by: Irit Goihman 
---
M automation/check-patch.repos.fc25
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Barak Korren: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved