Change in vdsm[master]: BZ#740887 Tune cache dirty ratio

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#740887 Tune cache dirty ratio
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/clientIF.py
Line 107:         self._networkSemaphore = threading.Semaphore()
Line 108:         self._shutdownSemaphore = threading.Semaphore()
Line 109:         self.log = log
Line 110:         self._recovery = True
Line 111:         self._tuneDirtyRatio()
wouldn't it be nicer if pushed into storage_dispatcher.__init__?

wait a minute... can vdsm even tune this? shouldn't this be root?
how about doing this in vdsmd^Wvdsm.tool?
Line 112:         self._libvirt = libvirtconnection.get()
Line 113:         self.serverPort = config.get('addresses',
'management_port')
Line 114:         self.serverIP = self._getServerIP()
Line 115:         self.server = self._createXMLRPCServer()


--
To view, visit http://gerrit.usersys.redhat.com/970
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5c8e4c0637c60092b89fba103b96b37bdafaa0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;