From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmpowerdown: implement base class interface
......................................................................
vmpowerdown: implement base class interface
The VmPowerdown class was not implementing fully its interface,
demanding to its derived class to fill the blanks. This made
pylint unhappy and the code a bit harder to follow.
In this patch we complete the VmPowerdown interface, so the derived
class need now to override the attributes.
This makes pylint happy and the code a bit easier to read.
Change-Id: I1a5f7880c5f3e8cc37c979294a501632d8dcbe8d
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmpowerdown.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/75853
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a5f7880c5f3e8cc37c979294a501632d8dcbe8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>