Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
......................................................................


Patch Set 2:

(1 comment)

....................................................
File lib/vdsm/vdscli.py.in
Line 37: class TransportWrapper:
Line 38:     def __init__(self, transport):
Line 39:         self._transport = transport
Line 40: 
Line 41:     def __getattr__(self, name):
I suspect that in this case, it would be clearer what you want to wrap.
Line 42:         if hasattr(self._transport, name):
Line 43:             func = getattr(self._transport, name)
Line 44:             return lambda *args, **kwargs: self._wrap(name, func, args, kwargs)
Line 45:         raise AttributeError(name)


-- 
To view, visit http://gerrit.ovirt.org/20627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes