Francesco Romani has uploaded a new change for review.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
numa: make use of DisconnectedVirDomain
avoid nasty AttributeError check.
Change-Id: I1dd095e23bc792b82def10db643762eac5e18a0e Signed-off-by: Francesco Romani fromani@redhat.com --- M vdsm/numaUtils.py 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/44762/1
diff --git a/vdsm/numaUtils.py b/vdsm/numaUtils.py index f6bd0da..3b462c0 100644 --- a/vdsm/numaUtils.py +++ b/vdsm/numaUtils.py @@ -125,10 +125,10 @@
def _get_vcpu_positioning(vm): - try: + if vm._dom.connected: + # TODO: remove this evilness return vm._dom.vcpus()[0] - except AttributeError: - # _dom may be reset to none asynchronously + else: return None
automation@ovirt.org has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 5: Code-Review-1
smells racy, please check
Dan Kenigsberg has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44762/5/vdsm/numaUtils.py File vdsm/numaUtils.py:
Line 130: evilness please be more explicit
evilness of accessing private vm._dom from here
Francesco Romani has abandoned this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Abandoned
wrong approach.
automation@ovirt.org has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org