Adam Litke has uploaded a new change for review.
Change subject: Remove unused ksm code to clean up sudoers ......................................................................
Remove unused ksm code to clean up sudoers
I am trying to reduce the number of commands we are adding to /etc/sudoers and noticed that the ksm ones are not even being used. The adjust function doesn't do anything because the ksmtuned service does not accept the 'retune' operation. The start and stop methods are never called.
Change-Id: Iafbae032adc8a752799aa8c976bcaeb6e7d728cd Signed-off-by: Adam Litke agl@us.ibm.com --- M vdsm/ksm.py M vdsm/libvirtvm.py M vdsm/sudoers.vdsm.in M vdsm/vm.py 4 files changed, 0 insertions(+), 27 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/3211/1 -- To view, visit http://gerrit.ovirt.org/3211 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Iafbae032adc8a752799aa8c976bcaeb6e7d728cd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove unused ksm code to clean up sudoers ......................................................................
Patch Set 1: I would prefer that you didn't submit this
cleaning the evil sudoers file is a noble cause, and ksmtune retune is indeed broken on Fedora - However, the code is generally useful in RHEL, where SysV service is still being used.
I would appreciate if you drop the never-used code in one patch, fix the 'retune' Fedora debacle in another, and drop this all in favor of MOM in a third patch ;-)
-- To view, visit http://gerrit.ovirt.org/3211 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iafbae032adc8a752799aa8c976bcaeb6e7d728cd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Adam Litke has abandoned this change.
Change subject: Remove unused ksm code to clean up sudoers ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/3211 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Iafbae032adc8a752799aa8c976bcaeb6e7d728cd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
vdsm-patches@lists.fedorahosted.org