Change in vdsm[master]: schema: add v2vJobs to HostStats

Shahar Havivi has uploaded a new change for review.

Change subject: schema: add v2vJobs to HostStats
......................................................................

schema: add v2vJobs to HostStats

v2vJobs reports via HostStats and needs to be declared in schema

Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com&gt;
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/44919/1

diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 4cac5ae..f21d174 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -1970,6 +1970,24 @@
           'score': 'uint'}}
 
 ##
+# @V2VJobs:
+#
+# Structure for current v2v jobs status
+#
+# @status:      Indicates jobs status (done, error, aborted, copying_disk,
+#               starting)
+#
+# @description: Description for the current status such as error or copying
+#               disk description.
+#
+# @progress:    Job progress between 0-100
+#
+# Since: 4.17.0
+##
+{'type': 'V2VJobs',
+ 'data': {'status': 'str', 'description': 'str',
'progress': 'uint'}}
+
+##
 # @HostStats:
 #
 # Statistics about this host.
@@ -2065,6 +2083,9 @@
 # @outgoingVmMigrations:   The number of VMs migrating away from this host
 #                          (new in version 4.17.0)
 #
+# @v2vJobs:                #optional Current v2v jobs that running/ended on
+#                          current host (new in version 4.17.0)
+#
 # Since: 4.10.0
 ##
 {'type': 'HostStats',
@@ -2086,7 +2107,8 @@
            'haStatus': 'HostedEngineStatus', '*bootTime':
'uint',
            'numaNodeMemFree': 'NumaNodeMemoryStatsMap',
            'cpuStatistics': 'CpuCoreStatsMap',
-           'incomingVmMigrations': 'uint',
'outgoingVmMigrations': 'uint'}}
+           'incomingVmMigrations': 'uint',
'outgoingVmMigrations': 'uint',
+           '*v2vJobs': 'V2VJobs'}}
 
 ##
 # @Host.getStats:


-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44919/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1984: #
Line 1985: # Since: 4.17.0
Line 1986: ##
Line 1987: {'type': 'V2VJobs',
Line 1988:  'data': {'status': 'str', 'description':
'str', 'progress': 'uint'}}
we should document that this is a map. See VmJobsMap as example.
Line 1989: 
Line 1990: ##
Line 1991: # @HostStats:
Line 1992: #


-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes

automation(a)ovirt.org has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 2: Code-Review+1

thanks, looks correct now. To verify: we have some basic schema compliancy tests, maybe
run 'make check' is a good start.

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 4: Code-Review+2 Verified+1

rebased to trigger CI jobs. Verified running make check, to have some basic schema
validation.

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 5:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: schema: add v2vJobs to HostStats
......................................................................


schema: add v2vJobs to HostStats

v2vJobs reports via HostStats and needs to be declared in schema

Backport-To: 3.6
Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/44919
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
Tested-by: Francesco Romani <fromani(a)redhat.com&gt;
Continuous-Integration: Jenkins CI
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 35 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: schema: add v2vJobs to HostStats
......................................................................


Patch Set 6:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No