Dan Kenigsberg has uploaded a new change for review.
Change subject: _createXMLRPCServer: avoid some code duplication ......................................................................
_createXMLRPCServer: avoid some code duplication
Change-Id: I50e5a92e20e307ae7acba4c1bf2411474b5bccd8 --- M vdsm/BindingXMLRPC.py 1 file changed, 14 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/1712/1 -- To view, visit http://gerrit.ovirt.org/1712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I50e5a92e20e307ae7acba4c1bf2411474b5bccd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: _createXMLRPCServer: avoid some code duplication ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
that change make a lot of sense.
-- To view, visit http://gerrit.ovirt.org/1712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I50e5a92e20e307ae7acba4c1bf2411474b5bccd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: _createXMLRPCServer: avoid some code duplication ......................................................................
Patch Set 2: Verified
Hi Dan,
I have just rebase your patch (the previous one was based on flowid patch). Now I will create the flowID patch based on this one.
Thanks!
-- To view, visit http://gerrit.ovirt.org/1712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I50e5a92e20e307ae7acba4c1bf2411474b5bccd8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: _createXMLRPCServer: avoid some code duplication ......................................................................
Patch Set 3: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I50e5a92e20e307ae7acba4c1bf2411474b5bccd8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: _createXMLRPCServer: avoid some code duplication ......................................................................
_createXMLRPCServer: avoid some code duplication
Change-Id: I50e5a92e20e307ae7acba4c1bf2411474b5bccd8 --- M vdsm/BindingXMLRPC.py 1 file changed, 10 insertions(+), 8 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1712 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I50e5a92e20e307ae7acba4c1bf2411474b5bccd8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
vdsm-patches@lists.fedorahosted.org