Change in vdsm[master]: [WIP] Enable deleteVolume for the merged internal volumes

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: [WIP] Enable deleteVolume for the merged internal volumes
......................................................................

[WIP] Enable deleteVolume for the merged internal volumes

Change-Id: I99044c9de79ee3c74ed1c010f6e573bcd3695da2
---
M vdsm/storage/volume.py
1 file changed, 20 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/2672/1
--
To view, visit http://gerrit.ovirt.org/2672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99044c9de79ee3c74ed1c010f6e573bcd3695da2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Itamar Heim has posted comments on this change.

Change subject: [WIP] Enable deleteVolume for the merged internal volumes
......................................................................


Patch Set 1:

ping?

-- 
To view, visit http://gerrit.ovirt.org/2672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99044c9de79ee3c74ed1c010f6e573bcd3695da2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Enable deleteVolume for the merged internal volumes
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/storage/volume.py
Line 391:                     # The child has no backing file. This is could be result
s/is//

Line 709:             volume = domain.produceVolume(self.imgUUID, volUUID)
better push to previous patch, it has caused me a little heart attack.

--
To view, visit http://gerrit.ovirt.org/2672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99044c9de79ee3c74ed1c010f6e573bcd3695da2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

Itamar Heim has abandoned this change.

Change subject: [WIP] Enable deleteVolume for the merged internal volumes
......................................................................


Abandoned

no reply - abandoning - please restore if still relevant

-- 
To view, visit http://gerrit.ovirt.org/2672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I99044c9de79ee3c74ed1c010f6e573bcd3695da2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;