Saggi Mizrahi has uploaded a new change for review.
Change subject: Split getSessionInfo() out of getdeviScsiInfo() ......................................................................
Split getSessionInfo() out of getdeviScsiInfo()
The original call is doing both things and a function should only do 1. This patch also makes the result a namedtuple instead of a regular tuple that is easier to handle programatically and converts all values to the appropriate types.
Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451 --- M vdsm/storage/iscsi.py M vdsm/storage/misc.py M vdsm/storage/multipath.py 3 files changed, 63 insertions(+), 29 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/1096/1 -- To view, visit http://gerrit.ovirt.org/1096 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Split getSessionInfo() out of getdeviScsiInfo() ......................................................................
Patch Set 8: (2 inline comments)
.................................................... File vdsm/storage/iscsi.py Line 342: IscsiDevice Maybe IscsiSession ?
.................................................... File vdsm/storage/multipath.py Line 290: sessionInfo["portal"] = str(sessionInfo["portal"]) Sorry, but lost you here. Why all this?
-- To view, visit http://gerrit.ovirt.org/1096 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has abandoned this change.
Change subject: Split getSessionInfo() out of getdeviScsiInfo() ......................................................................
Patch Set 8: Abandoned
Took a different direction
-- To view, visit http://gerrit.ovirt.org/1096 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org