Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Hello Jenkins CI, gerrit-hooks, Irit Goihman, Edward Haas,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/81150

to review the following change.

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
......................................................................

Revert "dpdk: add only non dpdk nics to aqcuired ifaces"

This reverts commit 936e6cc89aec8fb6a5894382ea1a349979c3fc06.

Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/81150/1

diff --git a/lib/vdsm/network/ovs/switch.py b/lib/vdsm/network/ovs/switch.py
index 64930c9..cff51b9 100644
--- a/lib/vdsm/network/ovs/switch.py
+++ b/lib/vdsm/network/ovs/switch.py
@@ -124,8 +124,7 @@
                 nic = attrs.get('nic')
                 bond = attrs.get('bonding')
                 sb = nic or bond
-                if not dpdk.is_dpdk(sb):
-                    self._acquired_ifaces.add(sb)
+                self._acquired_ifaces.add(sb)
 
                 bridge = self._get_ovs_bridge(sb)
                 self._create_nb(bridge, net)


-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/81150 )

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
......................................................................


Uploaded patch set 1.

-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: revert
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has abandoned this change. ( https://gerrit.ovirt.org/81150 )

Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
......................................................................


Abandoned

was a silly attempt to debug the CI failure

-- 
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;