2:12 a.m.
ShaoHe Feng has uploaded a new change for review.
Change subject: miscTests test failed, fix it
......................................................................
miscTests test failed, fix it
Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M tests/miscTests.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/6919/1
--
To view, visit http://gerrit.ovirt.org/6919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
2:35 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: miscTests test failed, fix it
......................................................................
Patch Set 2: Looks good to me, approved
Thanks, Saggi, for acking this.
--
To view, visit http://gerrit.ovirt.org/6919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:35 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: miscTests test failed, fix it
......................................................................
miscTests test failed, fix it
Saggi changes the raise exception of cleanupdir in 70ceb370 commit.
So fix the miscTests to assert the new exception.
Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M tests/miscTests.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Saggi Mizrahi: Looks good to me, but someone else must approve
Mark Wu: Verified; Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Zhou Zheng Sheng: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
2:20 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: miscTests test failed, fix it
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
3:33 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: miscTests test failed, fix it
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
this is practically the same as my own http://gerrit.ovirt.org/#/c/6878 which I wanted
Saggi to take a peek on.
--
To view, visit http://gerrit.ovirt.org/6919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
3:16 a.m.
Zhou Zheng Sheng has posted comments on this change.
Change subject: miscTests test failed, fix it
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
In commit 70ceb370, Saggi Mizrahi change the exception thrown, so we must change the
related exception expected in the unit test as well.
--
To view, visit http://gerrit.ovirt.org/6919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
3:12 a.m.
Mark Wu has posted comments on this change.
Change subject: miscTests test failed, fix it
......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae4234b4e2bd73b04605fed1779c04b36d081f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
4318
days inactive
4318
days old
vdsm-patches@lists.fedorahosted.org
6 comments
5 participants
participants (5)
-
Dan Kenigsberg -
shaohef＠linux.vnet.ibm.com -
smizrahi＠redhat.com -
wudxw＠linux.vnet.ibm.com -
zhshzhou＠linux.vnet.ibm.com