Francesco Romani has uploaded a new change for review.
Change subject: API: doc: reformat docstring for consistency ......................................................................
API: doc: reformat docstring for consistency
Change-Id: I13e3b6e85ab6a935ec15e581fba9fecc02fc588b Signed-off-by: Francesco Romani fromani@redhat.com --- M vdsm/API.py 1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/59668/1
diff --git a/vdsm/API.py b/vdsm/API.py index dd08774..2261865 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -1369,13 +1369,15 @@ def setLogLevel(self, level, name=''): """ Set verbosity level of vdsm's log. + Doesn't survive a restart.
- params - level: requested logging level. `logging.DEBUG` `logging.ERROR` - name: logger name to set. If not provided, defaults to the root - logger. Otherwise, tune the specific logger provided. - - Doesn't survive a restart + :param level: requested logging level. + Examples: `logging.DEBUG` `logging.ERROR` + :type level: string + :param name: logger name to set. If not provided, + defaults to the root logger. + Otherwise, tune the specific logger provided. + :type name: string """ logUtils.set_level(level, name) return dict(status=doneCode)
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Francesco Romani has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 1: Verified+1
doc-string only changes, if jenkins' happy, so we are.
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 5:
WTF?
../tests/run_tests_local.sh: line 14: 13802 Segmentation fault (core dumped) "$PYTHON_EXE" ../tests/testrunner.py --local-modules -A "type!='functional'" $@ make[3]: *** [check-local] Error 139
Dan Kenigsberg has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 5: Code-Review+2
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 6: Continuous-Integration+1
the segfault is horrible, but unrelated to this patch.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: API: doc: reformat docstring for consistency ......................................................................
API: doc: reformat docstring for consistency
Change-Id: I13e3b6e85ab6a935ec15e581fba9fecc02fc588b Signed-off-by: Francesco Romani fromani@redhat.com Reviewed-on: https://gerrit.ovirt.org/59668 Reviewed-by: Dan Kenigsberg danken@redhat.com Continuous-Integration: Dan Kenigsberg danken@redhat.com --- M vdsm/API.py 1 file changed, 8 insertions(+), 6 deletions(-)
Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified
Objections: Jenkins CI: Failed CI tests
gerrit-hooks has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency ......................................................................
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org