6:16 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: Fix the attachSD method for domain version 3
......................................................................
Fix the attachSD method for domain version 3
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
---
M vdsm/storage/sp.py
1 file changed, 24 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/4037/1
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
3:49 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Maor Lipchuk has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:40 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Fix attachSD and masterMigrate for domain version 3
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
---
M vdsm/storage/sp.py
1 file changed, 34 insertions(+), 12 deletions(-)
Approvals:
Haim Ateya: Verified
Federico Simoncelli: Looks good to me, approved
Dan Kenigsberg:
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:36 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Haim Ateya has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 16: Verified
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:33 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Federico Simoncelli has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 16: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:03 p.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Haim Ateya has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 15: Verified
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:10 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Allon Mureinik has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:30 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Allon Mureinik has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 13: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:04 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Maor Lipchuk has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:51 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Federico Simoncelli has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File vdsm/storage/sp.py
Line 859: if not newmsd.hasVolumeLeases():
I don't understand what you're proposing here. Do you want to get rid of
initSPMlease() in all cases?
Line 949: dom.releaseHostId(self.id)
It's out of the scope of this method to maintain the host id. In fact it was acquired
for the sole purpose of temporarily taking the SPM resource to avoid races with other DCs.
Keeping the host acquired here is an optimization that doesn't buy you much in terms
of performance and instead it's adding a possible mismatch if the domainMonitor thread
is not properly started.
I'd keep the code as it is now but if we really want to maintain the host id acquired
here then we might want to make sure to start the domainMonitor as well:
try:
dom.acquireClusterLock(self.id)
try:
[...]
finally:
dom.releaseClusterLock()
self.domainMonitor.startMonitoring(sdCache.produce(sdUUID), self.id)
except:
dom.releaseHostId(self.id)
And get rid of the updateMonitoringThreads() at the end.
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:48 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Eduardo has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/sp.py
Line 859: if not newmsd.hasVolumeLeases():
Since mixed pools are forbidden we can assume that the newmsd is using the same safelease
as curmsd.
Line 949: dom.releaseHostId(self.id)
Why are you releasing your Host ID?
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:49 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Allon Mureinik has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:35 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Federico Simoncelli has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 859: if not newmsd.hasVolumeLeases():
Not necessarily, it was a trick used (VERSION < 3) to speed up the acquirement process
(in case in the past the SPM wasn't cleanly released on the destination domain). With
VERSION == 3 it's completely wrong and it shouldn't be executed.
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:12 a.m.
New subject: Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3
Igor Lvovsky has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 859: if not newmsd.hasVolumeLeases():
we have initSPMlease() calls during domain creation.
Do we need same behaviour in these cases?
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:28 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Fix the attachSD method for domain version 3
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4348
days inactive
4400
days old
vdsm-patches@lists.fedorahosted.org
14 comments
7 participants
participants (7)
-
Allon Mureinik -
Dan Kenigsberg -
ewarszaw＠redhat.com -
Federico Simoncelli -
Haim Ateya -
Igor Lvovsky -
Maor Lipchuk