Change in vdsm[master]: vdsm: change default migration bandwidth in conf

Peter V. Saveliev has uploaded a new change for review.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

vdsm: change default migration bandwidth in conf

Libvirt changed the default behaviour in migration bandwith
definition. Prior to versions 0.10.x it used "0" to define
default 32MBps limit, now it uses "0" to define unlimited
speed.

This patch preserves the former way, when the default was
32MBps. It needed in enterprise environments, where mass
migration with unlimited bandwith can have a serious impact
on the network infrastructure.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=925981
Signed-off-by: Peter V. Saveliev 
Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
---
M lib/vdsm/config.py.in
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/13781/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 20edd2e..d58c3e2 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -55,9 +55,9 @@
             'Time to wait (in seconds) for migration destination to start '
             'listening before migration begins.'),

-        ('migration_max_bandwidth', '0',
-            'Maximum bandwidth for migration, in mbps, 0 means libvirt's '
-            'default (30mbps?).'),
+        ('migration_max_bandwidth', '32',
+            'Maximum bandwidth for migration, in MBps, 0 means libvirt's '
+            'default: 32MBps or unlimited, depending on the version.'),

('migration_monitor_interval', '10',
             'How often (in seconds) should the monitor thread pulse, 0 means '

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1894/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1945/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1894/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1945/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: oVirt Jenkins CI Server

Michal Skrivanek has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File lib/vdsm/config.py.in
Line 56:             'listening before migration begins.'),
Line 57: 
Line 58:         ('migration_max_bandwidth', '32',
Line 59:             'Maximum bandwidth for migration, in MBps, 0 means libvirt's '
Line 60:             'default: 32MBps or unlimited, depending on the version.'),
better just say unlimited, we don't care about old versions...
Line 61: 
Line 62:         ('migration_monitor_interval', '10',
Line 63:             'How often (in seconds) should the monitor thread pulse, 0 means '
Line 64:             'the thread is disabled.'),

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Peter V. Saveliev has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File lib/vdsm/config.py.in
Line 56:             'listening before migration begins.'),
Line 57: 
Line 58:         ('migration_max_bandwidth', '32',
Line 59:             'Maximum bandwidth for migration, in MBps, 0 means libvirt's '
Line 60:             'default: 32MBps or unlimited, depending on the version.'),
Peter, in the bug you mentioned something about the unit.
Is it MiB per second? If so it should be stated correctly and consistently  in the documentation.
Line 61: 
Line 62:         ('migration_monitor_interval', '10',
Line 63:             'How often (in seconds) should the monitor thread pulse, 0 means '
Line 64:             'the thread is disabled.'),

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Peter V. Saveliev has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File lib/vdsm/config.py.in
Line 56:             'listening before migration begins.'),
Line 57: 
Line 58:         ('migration_max_bandwidth', '32',
Line 59:             'Maximum bandwidth for migration, in MBps, 0 means libvirt's '
Line 60:             'default: 32MBps or unlimited, depending on the version.'),
Aargh. You're right, yes, it is MiBps, 1024^2 :|
Line 61: 
Line 62:         ('migration_monitor_interval', '10',
Line 63:             'How often (in seconds) should the monitor thread pulse, 0 means '
Line 64:             'the thread is disabled.'),

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1899/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1950/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Peter V. Saveliev has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 1: (2 inline comments)

....................................................
File lib/vdsm/config.py.in
Line 56:             'listening before migration begins.'),
Line 57: 
Line 58:         ('migration_max_bandwidth', '32',
Line 59:             'Maximum bandwidth for migration, in MBps, 0 means libvirt's '
Line 60:             'default: 32MBps or unlimited, depending on the version.'),
Done
Line 61: 
Line 62:         ('migration_monitor_interval', '10',
Line 63:             'How often (in seconds) should the monitor thread pulse, 0 means '
Line 64:             'the thread is disabled.'),

Line 56:             'listening before migration begins.'),
Line 57: 
Line 58:         ('migration_max_bandwidth', '32',
Line 59:             'Maximum bandwidth for migration, in MBps, 0 means libvirt's '
Line 60:             'default: 32MBps or unlimited, depending on the version.'),
Done
Line 61: 
Line 62:         ('migration_monitor_interval', '10',
Line 63:             'How often (in seconds) should the monitor thread pulse, 0 means '
Line 64:             'the thread is disabled.'),

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Peter V. Saveliev has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1899/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1950/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Michal Skrivanek has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

vdsm: change default migration bandwidth in conf

Libvirt changed the default behaviour in migration bandwith
definition. Prior to versions 0.10.x it used "0" to define
default 32MBps limit, now it uses "0" to define unlimited
speed.

This patch preserves the former way, when the default was
32MBps. It needed in enterprise environments, where mass
migration with unlimited bandwith can have a serious impact
on the network infrastructure.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=925981
Signed-off-by: Peter V. Saveliev 
Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
---
M lib/vdsm/config.py.in
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Peter V. Saveliev: Verified
  Michal Skrivanek: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: change default migration bandwidth in conf
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9f3ac98d1868504c04d80eea5fc50d1d8cb1939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server