From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: make sure that stomp connection is active before sending messages
......................................................................
stomp: make sure that stomp connection is active before sending messages
In may happen that client sends SEND frame before CONNECT and SUBSCRIBE
frames are processed by the server which can lead to server having no
knowledge to whom send response because subscription is not finalized
yet. We need to wait for server to respond with CONNECTED frame before
sending any rpc requests.
Here is the flow how the issue happens:
1. Client connects to the server
2. Client sends CONNECT and SUBSCRIBE frames
3. Client sends SEND fame
4. Server receives all 3 frames and starts to process them
5. Server attempts to send MESSAGE frame
6. Server sends CONNECTED
Change-Id: I4f6881d7966fa47031d027740633ca83c834387f
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncClientTests.py
2 files changed, 14 insertions(+), 6 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/49000
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f6881d7966fa47031d027740633ca83c834387f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>