From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: client cert check for IPv4 mapped addresses
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/76197/4/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 239:
Line 240: return False
Line 241:
Line 242: @staticmethod
Line 243: def compare_names(src_addr, cert_common_name):
can you add a CompareNameTest so what is added here is clearer and does not break?
Line 244: ip = IPAddress(src_addr)
Line 245: if ip.is_ipv4_mapped():
Line 246: src_addr = str(ip.ipv4())
Line 247:
--
To view, visit
https://gerrit.ovirt.org/76197
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic012664db7181ab703ec4de53a0ba7c225bb73f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes