4:39 p.m.
Hello Nir Soffer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32102
to review the following change.
Change subject: tests: Fix Python 2.6 compatibility
......................................................................
tests: Fix Python 2.6 compatibility
Recent tests use set comprehension which is available only in Python
2.7, failing builds on EL machines.
Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31785
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/toolTests.py
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/32102/1
diff --git a/tests/toolTests.py b/tests/toolTests.py
index f80c97e..53ddeba 100644
--- a/tests/toolTests.py
+++ b/tests/toolTests.py
@@ -58,8 +58,8 @@
configurator,
'_getConfigurers',
lambda: {
- 'a': MockModuleConfigurator('a', set('b')),
- 'b': MockModuleConfigurator('b', set('a'))
+ 'a': MockModuleConfigurator('a', set(['b'])),
+ 'b': MockModuleConfigurator('b', set(['a']))
}
)
def testDependencyCircle(self):
@@ -73,10 +73,10 @@
configurator,
'_getConfigurers',
lambda: {
- 'a': MockModuleConfigurator('a', {'b',
'd'}),
- 'b': MockModuleConfigurator('b', {'c'}),
- 'c': MockModuleConfigurator('c', {'e',
'd'}),
- 'd': MockModuleConfigurator('d', {'e',
'e'}),
+ 'a': MockModuleConfigurator('a', set(['b',
'd'])),
+ 'b': MockModuleConfigurator('b', set(['c'])),
+ 'c': MockModuleConfigurator('c', set(['e',
'd'])),
+ 'd': MockModuleConfigurator('d', set(['e',
'e'])),
'e': MockModuleConfigurator('e', set()),
'f': MockModuleConfigurator('f', set()),
@@ -107,7 +107,7 @@
configurator,
'_getConfigurers',
lambda: {
- 'a': MockModuleConfigurator('a', {'b',
'c'}),
+ 'a': MockModuleConfigurator('a', set(['b',
'c'])),
'b': MockModuleConfigurator('b', set()),
'c': MockModuleConfigurator('c', set())
}
--
To view, visit http://gerrit.ovirt.org/32102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
5:37 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Fix Python 2.6 compatibility
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/121/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:13 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Fix Python 2.6 compatibility
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
4:25 p.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tests: Fix Python 2.6 compatibility
......................................................................
tests: Fix Python 2.6 compatibility
Recent tests use set comprehension which is available only in Python
2.7, failing builds on EL machines.
Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31785
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32102
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Tested-by: mooli tayer <mtayer(a)redhat.com>
---
M tests/toolTests.py
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/32102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
6:01 a.m.
mooli tayer has posted comments on this change.
Change subject: tests: Fix Python 2.6 compatibility
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
5:26 p.m.
Nir Soffer has posted comments on this change.
Change subject: tests: Fix Python 2.6 compatibility
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf684f2dbee3a024d90d7d9fd7378636fad2ea8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3531
days inactive
3536
days old
vdsm-patches@lists.fedorahosted.org
5 comments
4 participants
participants (4)
-
Jenkins CI RO -
mtayer＠redhat.com -
Nir Soffer -
ybronhei＠redhat.com