Change in vdsm[master]: Add 'readonly' attribute to disk's libvirt XML

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Add 'readonly' attribute to disk's libvirt XML

Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 4 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/1049/1
--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 494:             drv['readonly'] = drv.get('readonly') or 'False'
internal boolean properties should better be boolean instead of str(boolean).

util.tobool() is just for that.

--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/vm.py
Line 494:             drv['readonly'] = drv.get('readonly') or 'False'
Actually, this parameter can't be passed in old style API.
So, I just can to put it False.

--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has submitted this change and it was merged.

Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................

Add 'readonly' attribute to disk's libvirt XML

Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Igor Lvovsky: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky