Change in vdsm[master]: boostrap completion: Restart vdsmd service.

Doron Fediuck has uploaded a new change for review.

Change subject: boostrap completion: Restart vdsmd service.
......................................................................

boostrap completion: Restart vdsmd service.

Recently we've fixed the functionality which avoids
reboot once bootstrap is completed. However, the vdsmd
service requiers restart in order to pick up the new
configuration and the new certificates issues during
the bootstrap.

This patch uses the same logic as the ovirt-node reboot
function, which reboots the machine or restarts the
vdsmd servide when reboot is avoided.

Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
---
M vds_bootstrap/vds_bootstrap_complete.py
1 file changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/2194/1
--
To view, visit http://gerrit.ovirt.org/2194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has submitted this change and it was merged.

Change subject: boostrap completion: Restart vdsmd service.
......................................................................


boostrap completion: Restart vdsmd service.

Recently we've fixed the functionality which avoids
reboot once bootstrap is completed. However, the vdsmd
service requiers restart in order to pick up the new
configuration and the new certificates issues during
the bootstrap.

This patch uses the same logic as the ovirt-node reboot
function, which reboots the machine or restarts the
vdsmd servide when reboot is avoided.

Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
---
M vds_bootstrap/vds_bootstrap_complete.py
1 file changed, 15 insertions(+), 4 deletions(-)

Approvals:
  Federico Simoncelli: 
  Doron Fediuck: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/2194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Doron Fediuck has posted comments on this change.

Change subject: boostrap completion: Restart vdsmd service.
......................................................................


Patch Set 2: Verified

Verified using latest engine patches.

--
To view, visit http://gerrit.ovirt.org/2194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: boostrap completion: Restart vdsmd service.
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: boostrap completion: Restart vdsmd service.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

minor (but annoying) issue, if you are touching this code area.

....................................................
File vds_bootstrap/vds_bootstrap_complete.py
Line 54:     print "<BSTRAP component='" + action + "'
status='OK' message='" + message + "' />"
would you please log this message, too?

--
To view, visit http://gerrit.ovirt.org/2194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;