Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32060
to review the following change.
Change subject: tool: Remove pointless __init__ methods
......................................................................
tool: Remove pointless __init__ methods
Some configurators had pointless __init__ methods. There is not need to
implement these if they are empty. Keeping them only cause developers to
copy and paste this useless code when they create new configurators.
Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/31740
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurators/__init__.py
M lib/vdsm/tool/configurators/sanlock.py
2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/32060/1
diff --git a/lib/vdsm/tool/configurators/__init__.py
b/lib/vdsm/tool/configurators/__init__.py
index 219d119..49071ff 100644
--- a/lib/vdsm/tool/configurators/__init__.py
+++ b/lib/vdsm/tool/configurators/__init__.py
@@ -44,9 +44,6 @@
class ModuleConfigure(object):
- def __init__(self):
- pass
-
def getName(self):
return None
diff --git a/lib/vdsm/tool/configurators/sanlock.py
b/lib/vdsm/tool/configurators/sanlock.py
index 566c5e5..9225252 100644
--- a/lib/vdsm/tool/configurators/sanlock.py
+++ b/lib/vdsm/tool/configurators/sanlock.py
@@ -36,9 +36,6 @@
SANLOCK_GROUPS = (constants.QEMU_PROCESS_GROUP, constants.VDSM_GROUP)
- def __init__(self):
- super(Sanlock, self).__init__()
-
def getName(self):
return 'sanlock'
--
To view, visit
http://gerrit.ovirt.org/32060
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>