From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: log call context for api calls
......................................................................
Patch Set 9: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/75517/9//COMMIT_MSG
Commit Message:
Line 20:
Line 21: and if the context is not available because the method was called
Line 22: internally we see:
Line 23:
Line 24: START getCapabilities() from=internal (api:41)
I don't see any reason to add labels
START [FUNC NAME] [optional SOURCE] [optional FLOW_ID]
FINISH [FUNC NAME] [optional SOURCE] [optional FLOW_ID]
I wouldn't include [Module:Line] and I would try to make it short and clean.
Line 25:
Line 26:
Line 27: Change-Id: I128a338037b22b43b1065cfb40ea95de6f371b99
--
To view, visit
https://gerrit.ovirt.org/75517
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I128a338037b22b43b1065cfb40ea95de6f371b99
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes