Change in vdsm[master]: net tests: Wait for link aggregation bonds to be in sync

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Wait for link aggregation bonds to be in sync
......................................................................

Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/73042/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2791:         ZEROMAC = '00:00:00:00:00:00'
Line 2792: 
Line 2793:         bond_1_partner_mac = ZEROMAC
Line 2794:         bond_2_partner_mac = ZEROMAC
Line 2795:         while bond_1_partner_mac == ZEROMAC or bond_2_partner_mac == ZEROMAC:
> add max attempts?

we must not block the test forever.
Line 2796:             status, msg, info = self.vdsm_net.getVdsCapabilities()
Line 2797:             bond_caps = info['bondings']
Line 2798:             bond_1_partner_mac = \
Line 2799:                 bond_caps[BONDING_NAME]['ad_partner_mac']

Line 2818:                 self.assertEqual(status, SUCCESS, msg)
Line 2819:                 self.assertBondExists(bond, pair)
Line 2820: 
Line 2821:             if mode == LINK_AGGR_MODE:
Line 2822:                 self._wait_link_aggr_mode_sync()
so, haven't you found a nicer to wait for this sync, using netlink events?

_wait_link_aggr_mode_sync() would be slightly less ugly if it received the bond names as args.
Line 2823: 
Line 2824:             status, msg, info = self.vdsm_net.getVdsCapabilities()
Line 2825:             bond_caps, nic_caps = info['bondings'], info['nics']
Line 2826:             try: