Change in vdsm[master]: Fixing unnecessary preparePath() call on recover.

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Fixing unnecessary preparePath() call on recover.
......................................................................

Fixing unnecessary preparePath() call on recover.

On behalf of Dan Kenisberg.

Change-Id: Ifca49f960d80176d5ddc594a2ae269cdaf13dec5
---
M vdsm/clientIF.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/950/1
--
To view, visit http://gerrit.ovirt.org/950
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifca49f960d80176d5ddc594a2ae269cdaf13dec5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fixing unnecessary preparePath() call on recover.
......................................................................


Fixing unnecessary preparePath() call on recover.

On behalf of Dan Kenisberg.

Change-Id: Ifca49f960d80176d5ddc594a2ae269cdaf13dec5
---
M vdsm/clientIF.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/950
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifca49f960d80176d5ddc594a2ae269cdaf13dec5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fixing unnecessary preparePath() call on recover.
......................................................................


Patch Set 2: Looks good to me, approved

If it's now tested, I'm good.

--
To view, visit http://gerrit.ovirt.org/950
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifca49f960d80176d5ddc594a2ae269cdaf13dec5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fixing unnecessary preparePath() call on recover.
......................................................................


Patch Set 2: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/950
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifca49f960d80176d5ddc594a2ae269cdaf13dec5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fixing unnecessary preparePath() call on recover.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/clientIF.py
Line 998:                         vmObj.getConfDevices[vm.DISK_DEVICES]
huh? isn't this a no-op?

The code I've sent to Edu included passing the DISKs to preparePaths.

--
To view, visit http://gerrit.ovirt.org/950
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifca49f960d80176d5ddc594a2ae269cdaf13dec5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;