10:44 a.m.
Lee Yarwood has uploaded a new change for review.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
blockSD: Ensure active volumes are refreshed before use.
At present we trust that active LVs represent the current state of a
given LV. This may not be the case if the LV has been modified
(extended, recreated etc) by another host while the LV is active on
the current host.
This change forces active non-special LVs to be refresh before use.
Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Signed-off-by: Lee Yarwood <lyarwood(a)redhat.com>
---
M vdsm/storage/blockSD.py
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/21387/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index d27f331..7d296b7 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -1059,14 +1059,23 @@
def activateVolumes(self, imgUUID, volUUIDs):
"""
- Activate all the volumes belonging to the image.
+ Activate all the volumes belonging to the image. Refresh any active
+ volumes that belong to the image as long as they are not special.
- imgUUID: the image to be deactivated.
+ imgUUID: the image to be activated.
allVols: getAllVolumes result.
If the image is based on a template image it will be activated.
"""
+ toRefresh = [ vol for vol in volUUIDs if vol not in SPECIAL_LVS and
+ lvm.isLVActive(self.sdUUID, vol)]
lvm.activateLVs(self.sdUUID, volUUIDs)
+
+ if toRefresh:
+ log.warning("The following volumes are already active and will be"
+ " refreshed before use : %s", toRefresh)
+ lvm.refreshLVs(self.sdUUID, toRefresh)
+
vgDir = os.path.join("/dev", self.sdUUID)
return self.createImageLinks(vgDir, imgUUID, volUUIDs)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
6:34 a.m.
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:45 a.m.
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7: Verified-1
Unfortunately while attempting to verify this change it appears that lvchange --refresh is
not having the desired effect on volumes that have been modified on other hosts.
For example a common flow where we have seen issues as a result of this in the past is
with the merging of snapshots. I've attempted a few of these while leaving one or more
volumes active a HSM. While this change does correctly call lvchange --refresh against
these before use on the HSM the underlying dm structure of the volume is not updated and
thus the guest is unable to boot. Maybe this is just a lvm2 bug but it really needs more
research before we verify this change.
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:56 a.m.
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7:
@Nir Isn't this avoided thanks to Eduardo's 'One shot prepare' patch [1]?
I still need to verify this patch series against master and will check that it doesn't
introduce any additional activation or refresh commands into the prepare flow.
[1] http://gerrit.ovirt.org/#/c/4220/
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:35 a.m.
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7: -Code-Review
(2 comments)
I see one problem - the active check and handling is now at the correct layer - but all
calls to prepareImage invoke prepareVolumePath which invokes activateVolume. So we may
invoke activateVolumes multiple times on same already activated volume, leading to
multiple unneeded and expensive refreshes.
This patch must ensure that we refresh active lvs only on the first time we found the lv
active, and never touch it after that.
....................................................
Commit Message
Line 8:
Line 9: At present we trust that active LVs represent the current state of a
Line 10: given LV. This may not be the case if the LV has been modified
Line 11: (extended, recreated etc) by another host while the LV is active on
Line 12: the current host.
See https://bugzilla.redhat.com/show_bug.cgi?id=1009812#c19 for context.
Line 13:
Line 14: This change forces active LVs that are part of a guest image to be
Line 15: refreshed before use.
Line 16:
....................................................
File vdsm/storage/blockSD.py
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active and will
be"
Line 1076: " refreshed before use : %s", toRefresh)
Line 1077: lvm.refreshLVs(self.sdUUID, toRefresh)
Can you be more specific?
Line 1078:
Line 1079: vgDir = os.path.join("/dev", self.sdUUID)
Line 1080: return self.createImageLinks(vgDir, imgUUID, volUUIDs)
Line 1081:
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:23 a.m.
Allon Mureinik has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7: Code-Review+1
+1, assuming the inline comments are fixed and the depended patch is merged.
@Lee - perhaps we should rebase on top of it, to ensure they're merged together?
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:01 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7:
(2 comments)
....................................................
Commit Message
Line 8:
Line 9: At present we trust that active LVs represent the current state of a
Line 10: given LV. This may not be the case if the LV has been modified
Line 11: (extended, recreated etc) by another host while the LV is active on
Line 12: the current host.
Could you detail how we can get to such a condition? http://gerrit.ovirt.org/#/c/21291/
fixes the two cases that I am aware of (auto activate on boot and vdsm crash after
activation).
Line 13:
Line 14: This change forces active LVs that are part of a guest image to be
Line 15: refreshed before use.
Line 16:
....................................................
File vdsm/storage/blockSD.py
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active and will
be"
Line 1076: " refreshed before use : %s", toRefresh)
Line 1077: lvm.refreshLVs(self.sdUUID, toRefresh)
until http://gerrit.ovirt.org/#/c/8382/ is in, this could be a problem for shared volumes,
which are written to by another VM.
Line 1078:
Line 1079: vgDir = os.path.join("/dev", self.sdUUID)
Line 1080: return self.createImageLinks(vgDir, imgUUID, volUUIDs)
Line 1081:
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
1:54 a.m.
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7:
Ignore the test failure, it is not relevant to this change.
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:53 a.m.
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Needs docstring fix and shorter warning may be also nice. +1 since I do not want to delay
this.
....................................................
File vdsm/storage/blockSD.py
Line 1059:
Line 1060: def activateVolumes(self, imgUUID, volUUIDs):
Line 1061: """
Line 1062: Activate all the volumes belonging to the image. Refresh any active
Line 1063: volumes that belong to the image as long as they are not special.
The docstring should have a one line title such as:
Activates or refresh all volumes belonging to the image.
Then you can explain why we should check which volumes are active and why it is important
to refresh them, mentioning the bug number.
Line 1064:
Line 1065: imgUUID: the image to be activated.
Line 1066: allVols: getAllVolumes result.
Line 1067:
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active and will
be"
Line 1076: " refreshed before use : %s", toRefresh)
We are refreshing now, so "will be refreshed before use" is not the best
warning. I would shorten this warning to:
"Refreshing active lvs: %s"
Line 1077: lvm.refreshLVs(self.sdUUID, toRefresh)
Line 1078:
Line 1079: vgDir = os.path.join("/dev", self.sdUUID)
Line 1080: return self.createImageLinks(vgDir, imgUUID, volUUIDs)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:55 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4706/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5506/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5585/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:54 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4705/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5505/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5584/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:44 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4701/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5501/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5580/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:56 p.m.
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 3:
(1 comment)
....................................................
Commit Message
Line 10: given LV. This may not be the case if the LV has been modified
Line 11: (extended, recreated etc) by another host while the LV is active on
Line 12: the current host.
Line 13:
Line 14: This change forces active non-special LVs to be refresh before use.
Add note that this is patch 3 of 3 - all must be merged to fix this bug.
Add bug-url
Line 15:
Line 16: Change-Id: If3058cded234500e01939e50b2485afebd7087a3
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:46 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4689/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5489/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5568/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:11 p.m.
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 3:
(2 comments)
Looks good, need to check if special lvs are handled in the modified code path.
....................................................
File vdsm/storage/blockSD.py
Line 1067:
Line 1068: If the image is based on a template image it will be activated.
Line 1069: """
Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in SPECIAL_LVS and
Line 1071: lvm.isLVActive(self.sdUUID, vol)]
Special lvs belong to an image?
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active and will
be"
Line 1068: If the image is based on a template image it will be activated.
Line 1069: """
Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in SPECIAL_LVS and
Line 1071: lvm.isLVActive(self.sdUUID, vol)]
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
I agree.
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active and will
be"
Line 1076: " refreshed before use : %s", toRefresh)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:37 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4700/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5500/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5579/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11 a.m.
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 3:
(1 comment)
....................................................
File vdsm/storage/blockSD.py
Line 1068: If the image is based on a template image it will be activated.
Line 1069: """
Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in SPECIAL_LVS and
Line 1071: lvm.isLVActive(self.sdUUID, vol)]
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
Nir, just to answer a question you asked before regarding passing all volumes to the
activateLVs method. I could create a toActivate list here and only pass these but that
duplicates the logic already in the activateLVs method. I don't want to touch that
method now so it's just easier to pass everything through and let it filter them out.
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active and will
be"
Line 1076: " refreshed before use : %s", toRefresh)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:58 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4692/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5492/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5571/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:52 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4691/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5491/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5570/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:20 p.m.
Itamar Heim has abandoned this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Abandoned
no reply - abandoning - please restore if still relevant
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:15 a.m.
Itamar Heim has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
......................................................................
Patch Set 7:
ping - still relevant?
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3648
days inactive
3822
days old
vdsm-patches@lists.fedorahosted.org
20 comments
6 participants
participants (6)
-
Allon Mureinik -
Dan Kenigsberg -
iheim＠redhat.com -
Jenkins CI RO -
lyarwood＠redhat.com -
Nir Soffer