1:06 a.m.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Adding requirement for cyrus-sasl-lib and modify the default path
Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114993
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M configure.ac
M vdsm.spec.in
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/29625/1
diff --git a/configure.ac b/configure.ac
index 4d03bc7..9dc60bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -232,7 +232,7 @@
AC_PATH_PROG([RM_PATH], [rm], [/bin/rm])
AC_PATH_PROG([RPM_PATH], [rpm], [/bin/rpm])
AC_PATH_PROG([RSYNC_PATH], [rsync], [/usr/bin/rsync])
-AC_PATH_PROG([SASLPASSWD2_PATH], [saslpasswd2], [/sbin/saslpasswd2])
+AC_PATH_PROG([SASLPASSWD2_PATH], [saslpasswd2], [/usr/bin/saslpasswd2])
AC_PATH_PROG([SED_PATH], [sed], [/bin/sed])
AC_PATH_PROG([SERVICE_PATH], [service], [/sbin/service])
AC_PATH_PROG([SETSID_PATH], [setsid], [/usr/bin/setsid])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index dfca5bd..0a74c7c 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -66,6 +66,7 @@
BuildRequires: python-nose
BuildRequires: python-netaddr
BuildRequires: rpm-build
+BuildRequires: cyrus-sasl-lib
# BuildRequires needed by the tests during the build
BuildRequires: dosfstools
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7:32 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:55 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1572/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5557/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3715/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:46 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Adding requirement for cyrus-sasl-lib and modify the default path
Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114993
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/29625
Reviewed-by: Alon Bar-Lev <alonbl(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M configure.ac
M vdsm.spec.in
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yaniv Bronhaim: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
7:46 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 2: Code-Review+2
I won't mind dropping paths one at a time; but this patch is fine, too. Please
backport.
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:41 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10011/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10796/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/79/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/90/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10953/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:30 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:15 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 1:
Alon, wouldn't you prefer removing all references to
SASLPASSWD2_PATH, and replace them with a simple 'saslpasswd2' string?
this should be done consistently to all utilities... no reason to do this exceptional.
the solution in this patch does not change methodology, changing methodology can be done
in different horizontal patch.
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:38 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 1:
Alon, wouldn't you prefer removing all references to SASLPASSWD2_PATH, and replace
them with a simple 'saslpasswd2' string?
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Katarzyna Jachim <katarzyna.jachim(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:32 a.m.
Oved Ourfali has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:59 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:21 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default path
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9980/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10765/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/77/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/88/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10922/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/29625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If030cc6f31382629df843e185b23678052e90fcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3617
days inactive
3617
days old
vdsm-patches@lists.fedorahosted.org
11 comments
5 participants
participants (5)
-
Alon Bar-Lev -
Dan Kenigsberg -
Jenkins CI RO -
Oved Ourfali -
ybronhei＠redhat.com