Change in vdsm[master]: getDevInfo: report partioned devices, too

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: getDevInfo: report partioned devices, too
......................................................................

getDevInfo: report partioned devices, too

One cannot create a PV on a partitioned device, and therefor such
devices where not reported to Engine. This proved surprising to users
who woder where their LUN disappeared.

Vdsm should report all devices, and ovirt-engine should mark partitioned
devices as unworthy of a PV. In the future, Vdsm may allow to forcefully
remove a partition table from a device, to make it usable as a PV.

Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
---
M vdsm/storage/hsm.py
1 file changed, 10 insertions(+), 6 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/944/1
--
To view, visit http://gerrit.ovirt.org/944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: getDevInfo: report partioned devices, too
......................................................................

Patch Set 2: Looks good to me, approved

by Ayal

--
To view, visit http://gerrit.ovirt.org/944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

Ayal Baron has posted comments on this change.

Change subject: getDevInfo: report partioned devices, too
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: getDevInfo: report partioned devices, too
......................................................................

Patch Set 3: Verified; Looks good to me, approved

Ack'ed online by Livnat

--
To view, visit http://gerrit.ovirt.org/944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

Change in vdsm[master]: getDevInfo: report partitioned devices, too

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: getDevInfo: report partitioned devices, too
......................................................................

Patch Set 4: Verified; Looks good to me, approved

rebasing...

--
To view, visit http://gerrit.ovirt.org/944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

Change in vdsm[master]: getDevInfo: report partitioned devices, too

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: getDevInfo: report partitioned devices, too
......................................................................

getDevInfo: report partitioned devices, too

One cannot create a PV on a partitioned device, and therefor such
devices where not reported to Engine. This proved surprising to users
who wonder where their LUN disappeared.

Vdsm should report all devices, and ovirt-engine should mark partitioned
devices as unworthy of a PV. In the future, Vdsm may allow to forcefully
remove a partition table from a device, to make it usable as a PV.

Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
---
M vdsm/storage/hsm.py
1 file changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf