Change in vdsm[master]: network: test: test if bonding is successfully removed

Petr Horáček has uploaded a new change for review.

Change subject: network: test: test if bonding is successfully removed
......................................................................

network: test: test if bonding is successfully removed

Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Signed-off-by: Petr Horáček <phoracek(a)redhat.com&gt;
---
M tests/functional/networkTests.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/37882/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index aac1f01..55b6f3f 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -480,6 +480,7 @@
                 self.assertNetworkDoesntExist(vlan_net)
                 self.assertVlanDoesntExist(BONDING_NAME + '.' +
                                            networks[vlan_net]['vlan'])
+                self.assertBondDoesntExist(BONDING_NAME, nics)
 
     @cleanupNet
     @permutations([[True], [False]])
@@ -498,6 +499,7 @@
                 {BONDING_NAME: {'remove': True}}, NOCHK)
             self.assertEqual(status, SUCCESS, msg)
             self.assertNetworkDoesntExist(NETWORK_NAME)
+            self.assertBondDoesntExist(BONDING_NAME, nics)
 
     @cleanupNet
     @permutations([[True], [False]])
@@ -532,6 +534,7 @@
                 {},
                 {BONDING_NAME: {'remove': True}}, NOCHK)
             self.assertEqual(status, SUCCESS, msg)
+            self.assertBondDoesntExist(BONDING_NAME, nics)
 
     @cleanupNet
     def testSetupNetworksDelOneOfBondNets(self):
@@ -568,6 +571,7 @@
                 {NETA_NAME: {'remove': True}},
                 {BONDING_NAME: {'remove': True}}, NOCHK)
             self.assertEqual(status, SUCCESS, msg)
+            self.assertBondDoesntExist(BONDING_NAME, nics)
 
     @cleanupNet
     @permutations([[True], [False]])
@@ -2263,3 +2267,4 @@
             status, msg = self.vdsm_net.setupNetworks(
                 {}, {BONDING_NAME: {'remove': True}}, NOCHK)
             self.assertEqual(status, SUCCESS, msg)
+            self.assertBondDoesntExist(BONDING_NAME, nics)


-- 
To view, visit http://gerrit.ovirt.org/37882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: network: test: test if bonding is successfully removed
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Petr Horáček has posted comments on this change.

Change subject: network: test: test if bonding is successfully removed
......................................................................


Patch Set 1:

this test now fails, if we call remove just on bonding and not upper network, bonding is
not removad

-- 
To view, visit http://gerrit.ovirt.org/37882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: network: test: test if bonding is successfully removed
......................................................................


Patch Set 1: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15763/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14962/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15933/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/... : The patch
does not pass the network functional tests

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/739/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Petr Horáček has posted comments on this change.

Change subject: network: test: test if bonding is successfully removed
......................................................................


Patch Set 1:

Tests pass except testSetupNetworksAddBondWithManyVlans, which ends with
'AssertionError: bond11 found unexpectedly', we should probably do something about
it!

-- 
To view, visit https://gerrit.ovirt.org/37882
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Petr Horáček has abandoned this change.

Change subject: network: test: test if bonding is successfully removed
......................................................................


Abandoned

We dont need this anymore with kernelconfig

-- 
To view, visit https://gerrit.ovirt.org/37882
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: network: test: test if bonding is successfully removed
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/37882
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd6052676c20904e8f104616dc4e25d4616f71e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No