Change in vdsm[master]: join supervdsm subprocess after terminated to avoid defunct ...

Royce Lv has uploaded a new change for review.

Change subject: join supervdsm subprocess after terminated to avoid defunct status
......................................................................

join supervdsm subprocess after terminated to avoid defunct status

After validateAccess there leaves a defunct process
clear it by join after termination

Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Signed-off-by: Royce Lv
---
M vdsm/supervdsmServer.py
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/6503/1
--
To view, visit http://gerrit.ovirt.org/6503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: join supervdsm subprocess after terminated to avoid defunct status
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

saggi, could you take a look?

....................................................
File vdsm/supervdsmServer.py
Line 188:         proc.join()
I'm a bit worried about the child getting hung on a lost nfs mount. this line would make the parent block as well.

--
To view, visit http://gerrit.ovirt.org/6503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: join supervdsm subprocess after terminated to avoid defunct status
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 184: 
Line 185:         res, err = pipe.recv()
Line 186:         pipe.send("Bye")
Line 187:         proc.terminate()
Line 188:         proc.join()
We might just need to periodically do wait(WNOHANG) to collect zombie babies. But I may just be overreacting?
Line 189:         if err is not None:
Line 190:             raise err
Line 191: 
Line 192:         return res

--
To view, visit http://gerrit.ovirt.org/6503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: join supervdsm subprocess after terminated to avoid defunct status
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 184: 
Line 185:         res, err = pipe.recv()
Line 186:         pipe.send("Bye")
Line 187:         proc.terminate()
Line 188:         proc.join()
or ignore SIGCHLD? ignore this signal there won't produce any zombie process
Line 189:         if err is not None:
Line 190:             raise err
Line 191: 
Line 192:         return res

--
To view, visit http://gerrit.ovirt.org/6503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has abandoned this change.

Change subject: join supervdsm subprocess after terminated to avoid defunct status
......................................................................

Patch Set 1: Abandoned

start to using Saggi's zombie reaper

--
To view, visit http://gerrit.ovirt.org/6503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Yaniv Bronhaim has posted comments on this change.

Change subject: join supervdsm subprocess after terminated to avoid defunct status
......................................................................

Patch Set 1:

Where is the patch with the zombieReaper? Can you add a link? 
ZombieReaper.autoReapPid can also cause the parent some blocking issues.

--
To view, visit http://gerrit.ovirt.org/6503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcfb3b467e9226f14a4ebc2845ff2db0f19b5f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server