Change in vdsm[master]: Pass the direct disk in cmdLine.

Eduardo has uploaded a new change for review.

Change subject: Pass the direct disk in cmdLine.
......................................................................

Pass the direct disk in cmdLine.

Change-Id: I971e2c0d60043f0ee0c25a30156edd770ec22dfb
---
M vdsm/libvirtvm.py
1 file changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/259/1
--
To view, visit http://gerrit.ovirt.org/259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I971e2c0d60043f0ee0c25a30156edd770ec22dfb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

Eduardo has abandoned this change.

Change subject: Pass the direct disk in cmdLine.
......................................................................


Patch Set 3: Abandoned

Superseed by Change I513ebf1c

--
To view, visit http://gerrit.ovirt.org/259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I971e2c0d60043f0ee0c25a30156edd770ec22dfb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: ilvovsky(a)gmail.com

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Pass the direct disk in cmdLine.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

please also verify that this works on recovery and migration.

....................................................
File vdsm/libvirtvm.py
Line 1004:                 drv.iface = drive['if']
gosh, it is ugly. not your fault, of course.

how about passing **{'if': drive['if']} ?

--
To view, visit http://gerrit.ovirt.org/259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I971e2c0d60043f0ee0c25a30156edd770ec22dfb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)gmail.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Pass the direct disk in cmdLine.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I971e2c0d60043f0ee0c25a30156edd770ec22dfb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;