Change in vdsm[master]: pep8: use multiline blacklist

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: pep8: use multiline blacklist
......................................................................

pep8: use multiline blacklist

Yaniv thinks it's nicer that way.

Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M Makefile.am
1 file changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/25416/1

diff --git a/Makefile.am b/Makefile.am
index 3f4266c..4c8781f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -53,7 +53,11 @@
 WITH_HOOKS = --define="with_hooks 1"
 endif
 
-PEP8_BLACKLIST = config.py,constants.py,crossImportsTests.py,vdsm.py
+PEP8_BLACKLIST = config.py \
+	constants.py \
+	crossImportsTests.py \
+	vdsm.py \
+	$(NULL)
 
 SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
 	'lv' from line .*"
@@ -64,7 +68,10 @@
 		grep -w -v $(SKIP_PYFLAKES_ERR) | \
 		while read LINE; do echo "$$LINE"; false; done
 	$(PEP8) --version
-	$(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' .
+	for x in $(PEP8_BLACKLIST); do \
+	    exclude="$${exclude},$${x}" ; \
+	done ; \
+	$(PEP8) --exclude=$${exclude} --filename '*.py,*.py.in' .
 	@if test -f .gitignore; then \
 	  for i in `git ls-files \*.in`; do \
 	    if ! grep -q -x $${i%%.in} .gitignore; then \


-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: pep8: use multiline blacklist
......................................................................


pep8: use multiline blacklist

Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/25416
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M Makefile.am
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 3: Verified+1 Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 3: Code-Review+1

with that its easier to add files and not pass the line limit, if one day we'll get to
it. although this dirty loop in the middle, i would take it

-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7464/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6673/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7574/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25416/2/Makefile.am
File Makefile.am:

Line 71: 	$(PEP8) --version
Line 72: 	for x in $(PEP8_BLACKLIST); do \
Line 73: 	    exclude="$${exclude},$${x}" ; \
Line 74: 	done ; \
Line 75: 	$(PEP8) --exclude=$${exclude} --filename '*.py,*.py.in' .
>  i didn't think about that... good point for not having the list
/me doesn't understand your comment! If you want me to abandon the patch just
say.
Line 76: 	@if test -f .gitignore; then \
Line 77: 	  for i in `git ls-files \*.in`; do \
Line 78: 	    if ! grep -q -x $${i%%.in} .gitignore; then \
Line 79: 	      echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \


-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Yaniv Bronhaim has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/25416/2/Makefile.am
File Makefile.am:

Line 71: 	$(PEP8) --version
Line 72: 	for x in $(PEP8_BLACKLIST); do \
Line 73: 	    exclude="$${exclude},$${x}" ; \
Line 74: 	done ; \
Line 75: 	$(PEP8) --exclude=$${exclude} --filename '*.py,*.py.in' .
i didn't think about that... good point for not having the list
Line 76: 	@if test -f .gitignore; then \
Line 77: 	  for i in `git ls-files \*.in`; do \
Line 78: 	    if ! grep -q -x $${i%%.in} .gitignore; then \
Line 79: 	      echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \


-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7436/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6643/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7545/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 1:

just want to keep all files' lists in the same format

-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25416/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-03-05 13:19:49 +0000
Line 6: 
Line 7: pep8: use multiline blacklist
Line 8: 
Line 9: Yaniv thinks it's nicer that way.
>  you don't need to mention that. please remove, the title is
> enough 
The point is that I am not convinced that I agree with you here...
Line 10: 
Line 11: Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15


-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Yaniv Bronhaim has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25416/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-03-05 13:19:49 +0000
Line 6: 
Line 7: pep8: use multiline blacklist
Line 8: 
Line 9: Yaniv thinks it's nicer that way.
you don't need to mention that. please remove, the title is enough
Line 10: 
Line 11: Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15


-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7419/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6626/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7528/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No