1:32 a.m.
Vered Volansky has uploaded a new change for review.
Change subject: sdc: Change error messages to info
......................................................................
sdc: Change error messages to info
Two informative, non-error log messages were logged as error and are now
logged as info:
1._findDomain - looking for unfetched domain
2._findUnfetchedDomain - looking for domain
Also an error is raised in the process, now logged as info.
Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
Bug-url: https://bugzilla.redhat.com/1031814
---
M vdsm/storage/sdc.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/21597/1
diff --git a/vdsm/storage/sdc.py b/vdsm/storage/sdc.py
index 2767d6c..bb8b93f 100644
--- a/vdsm/storage/sdc.py
+++ b/vdsm/storage/sdc.py
@@ -134,13 +134,13 @@
try:
findMethod = self.knownSDs[sdUUID]
except KeyError:
- self.log.error("looking for unfetched domain %s", sdUUID)
+ self.log.info("looking for unfetched domain %s", sdUUID)
findMethod = self._findUnfetchedDomain
try:
dom = findMethod(sdUUID)
except se.StorageDomainDoesNotExist:
- self.log.error("domain %s not found", sdUUID, exc_info=True)
+ self.log.info("domain %s not found", sdUUID, exc_info=True)
raise
else:
return dom
@@ -151,7 +151,7 @@
import localFsSD
import nfsSD
- self.log.error("looking for domain %s", sdUUID)
+ self.log.info("looking for domain %s", sdUUID)
# The order is somewhat important, it's ordered
# by how quickly get can find the domain. For instance
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
1:39 a.m.
Sergey Gotliv has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1:
(1 comment)
We all know that for each FC domain we'll see that message at least once and since
this is expected behavior and won't be changed in the near future, why not debug or
info?
....................................................
File vdsm/storage/sdc.py
Line 139:
Line 140: try:
Line 141: dom = findMethod(sdUUID)
Line 142: except se.StorageDomainDoesNotExist:
Line 143: self.log.info("domain %s not found", sdUUID,
exc_info=True)
This error is real.
Line 144: raise
Line 145: else:
Line 146: return dom
Line 147:
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
2:56 a.m.
Vered Volansky has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1:
This is going to be n'acked, just for due process - the bug url is actually
https://bugzilla.redhat.com/show_bug.cgi?id=1031881
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:14 p.m.
Itamar Heim has abandoned this change.
Change subject: sdc: Change error messages to info
......................................................................
Abandoned
no reply - abandoning - please restore if still relevant
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:12 a.m.
Nir Soffer has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1:
(4 comments)
....................................................
Commit Message
Line 10: logged as info:
Line 11: 1._findDomain - looking for unfetched domain
Line 12: 2._findUnfetchedDomain - looking for domain
Line 13:
Line 14: Also an error is raised in the process, now logged as info.
We can see what was changed in the code. Can you explain why did make those changes?
Line 15:
Line 16: Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Line 17: Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
....................................................
File vdsm/storage/sdc.py
Line 133: def _findDomain(self, sdUUID):
Line 134: try:
Line 135: findMethod = self.knownSDs[sdUUID]
Line 136: except KeyError:
Line 137: self.log.info("looking for unfetched domain %s", sdUUID)
Looks like debug message to me.
Line 138: findMethod = self._findUnfetchedDomain
Line 139:
Line 140: try:
Line 141: dom = findMethod(sdUUID)
Line 139:
Line 140: try:
Line 141: dom = findMethod(sdUUID)
Line 142: except se.StorageDomainDoesNotExist:
Line 143: self.log.info("domain %s not found", sdUUID,
exc_info=True)
Is this a real error or normal condition?
Line 144: raise
Line 145: else:
Line 146: return dom
Line 147:
Line 150: import glusterSD
Line 151: import localFsSD
Line 152: import nfsSD
Line 153:
Line 154: self.log.info("looking for domain %s", sdUUID)
Looks like debug message to me.
Line 155:
Line 156: # The order is somewhat important, it's ordered
Line 157: # by how quickly get can find the domain. For instance
Line 158: # if an nfs mount is unavailable we will get stuck
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
3:08 a.m.
Nir Soffer has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1:
And it should be Bug-Url and not Bug-url :-)
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:08 a.m.
Eduardo has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1: Code-Review-2
Already discussed.
There is no spontaneous SD generation.
Should not be unfetched domains, then if such thing exists, they should be reported as
ERROR.
An ERROR log is not a bug, is for help developers to understand degraded conditions or
raise eyebrows.
This log is no so frequent nor is the root cause of the issue here.
Changing to info or debug is misleading and improve nothing.
grep ERROR for opening bugs is a bad practice.
The log dissapeared from 3.2.
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:35 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4865/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5665/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5750/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:33 a.m.
Vered Volansky has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-HasComments: No
2:44 p.m.
Itamar Heim has posted comments on this change.
Change subject: sdc: Change error messages to info
......................................................................
Patch Set 1:
ping?
--
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3651
days inactive
3818
days old
vdsm-patches@lists.fedorahosted.org
9 comments
6 participants
participants (6)
-
ewarszaw＠redhat.com -
iheim＠redhat.com -
Jenkins CI RO -
Nir Soffer -
sgotliv＠redhat.com -
vvolansk＠redhat.com