Change in vdsm[master]: Online check ksmState and ksmPages.

Amador Pahim has uploaded a new change for review.

Change subject: Online check ksmState and ksmPages.
......................................................................

Online check ksmState and ksmPages.

Currently ksmState and ksmPages is updated only when adjust()
is called (vm._startUnderlyingVm() and libvirt.releaseVm()).
Since ksmtuned can turn on/off ksm any time, vdsm will report
inaccurate information until adjust() be called.
This patch changes ksmState and ksmPages update to every API
call, reflecting always the accurate information.

Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Signed-off-by: Amador Pahim 
---
M vdsm/API.py
M vdsm/ksm.py
2 files changed, 25 insertions(+), 22 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/9510/1

diff --git a/vdsm/API.py b/vdsm/API.py
index 0710191..a0f2067 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1124,8 +1124,8 @@
             stats.update(self._cif.mom.getKsmStats())
         else:
             stats['momStatus'] = 'disabled'
-            stats['ksmState'] = self._cif.ksmMonitor.state
-            stats['ksmPages'] = self._cif.ksmMonitor.pages
+            stats['ksmState'] = self._ksmState()
+            stats['ksmPages'] = self._ksmPages()
             stats['ksmCpu'] = self._cif.ksmMonitor.cpuUsage
             stats['memShared'] = self._memShared() / Mbytes

@@ -1372,6 +1372,18 @@
         """
         return (self._cif.ksmMonitor.memsharing() * PAGE_SIZE_BYTES)

+    def _ksmState(self):
+        """
+        Return ksm running state.
+        """
+        return (self._cif.ksmMonitor.running())
+
+    def _ksmPages(self):
+        """
+        Return how many pages to scan before ksm will sleep.
+        """
+        return (self._cif.ksmMonitor.npages())
+
     def _memCommitted(self):
         """
         Return the amount of memory (Mb) committed for VMs
diff --git a/vdsm/ksm.py b/vdsm/ksm.py
index 3037a65..3c858b6 100644
--- a/vdsm/ksm.py
+++ b/vdsm/ksm.py
@@ -55,7 +55,6 @@
     def run(self):
         start()
         try:
-            self.state, self.pages = self.readState()
             KSM_MONITOR_INTERVAL = 60
             jiff0 = self._getKsmdJiffies()
             while True:
@@ -66,9 +65,6 @@
                 jiff0 = jiff1
         except:
             self._cif.log.error("Error monitoring KSM", exc_info=True)
-
-    def readState(self):
-        return running(), npages()

def adjust(self):
         """Adjust ksm's vigor
@@ -81,10 +77,9 @@
         try:
             utils.execCmd([constants.EXT_SERVICE, 'ksmtuned', 'retune'],
                           sudo=True)
-            self.state, self.pages = self.readState()
         finally:
             self._lock.release()
-        return self.state
+        return self.running()

def memsharing(self):
         try:
@@ -92,21 +87,17 @@
         except:
             return 0

+    def running(self):
+        try:
+            return (int(file('/sys/kernel/mm/ksm/run').read()) & 1 == 1)
+        except:
+            return False

-def running():
-    try:
-        state = int(file('/sys/kernel/mm/ksm/run').read()) & 1 == 1
-        return state
-    except:
-        return False
-
-
-def npages():
-    try:
-        npages = int(file('/sys/kernel/mm/ksm/pages_to_scan').read())
-        return npages
-    except:
-        return 0
+    def npages(self):
+        try:
+            return (int(file('/sys/kernel/mm/ksm/pages_to_scan').read()))
+        except:
+            return 0

def start():

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/163/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/197/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/163/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/197/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: oVirt Jenkins CI Server

Laszlo Hornyak has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

looks good, I will trz to verifz

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Amador Pahim has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

it seems that this patch include more changes than the ones required to report the up-to-date state of ksm.

....................................................
File vdsm/API.py
Line 1371:         Return an approximation of memory shared by VMs thanks to KSM.
Line 1372:         """
Line 1373:         return (self._cif.ksmMonitor.memsharing() * PAGE_SIZE_BYTES)
Line 1374: 
Line 1375:     def _ksmState(self):
the API object is too big as it is. adding ksm-specific functionality to it is not good modeling.
Line 1376:         """
Line 1377:         Return ksm running state.
Line 1378:         """
Line 1379:         return (self._cif.ksmMonitor.running())

....................................................
File vdsm/ksm.py
Line 86:             return (int(file('/sys/kernel/mm/ksm/pages_sharing').read()))
Line 87:         except:
Line 88:             return 0
Line 89: 
Line 90:     def running(self):
why is it helpful to make these object methods? I do not see they are using self.
Line 91:         try:
Line 92:             return (int(file('/sys/kernel/mm/ksm/run').read()) & 1 == 1)
Line 93:         except:
Line 94:             return False

Line 88:             return 0
Line 89: 
Line 90:     def running(self):
Line 91:         try:
Line 92:             return (int(file('/sys/kernel/mm/ksm/run').read()) & 1 == 1)
this is not C, so what is the benefit in the added parenthesis?
Line 93:         except:
Line 94:             return False
Line 95: 
Line 96:     def npages(self):

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/251/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/285/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/251/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/285/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/API.py
Line 1126:             stats['momStatus'] = self._cif.mom.getStatus()
Line 1127:             stats.update(self._cif.mom.getKsmStats())
Line 1128:         else:
Line 1129:             stats['momStatus'] = 'disabled'
Line 1130:             stats['ksmState'] = self._cif.ksmState()
this would explode, as _cif has no ksmState attribute. You probably want to call ksm.running().
Line 1131:             stats['ksmPages'] = self._cif.ksmPages()
Line 1132:             stats['ksmCpu'] = self._cif.ksmMonitor.cpuUsage
Line 1133:             stats['memShared'] = self._memShared() / Mbytes
Line 1134:

....................................................
File vdsm/ksm.py
Line 87:         except:
Line 88:             return 0
Line 89: 
Line 90: 
Line 91: def ksmState():
I don't think there is any urgent reason to change anything in this function.

please concentrate the patch on the bug fixing. refactoring can wait to a separate patch (and frankly, I do not think it is required).
Line 92:     try:
Line 93:         return int(file('/sys/kernel/mm/ksm/run').read()) & 1 == 1
Line 94:     except:
Line 95:         return False

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/252/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/286/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/252/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/286/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/API.py
Line 1126:             stats['momStatus'] = self._cif.mom.getStatus()
Line 1127:             stats.update(self._cif.mom.getKsmStats())
Line 1128:         else:
Line 1129:             stats['momStatus'] = 'disabled'
Line 1130:             stats['ksmState'] = self._cif.running()
are you sure this has been tested? clientIF does not have a "running" method.
Line 1131:             stats['ksmPages'] = self._cif.npages()
Line 1132:             stats['ksmCpu'] = self._cif.ksmMonitor.cpuUsage
Line 1133:             stats['memShared'] = self._memShared() / Mbytes
Line 1134:

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Amador Pahim has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 3: (1 inline comment)

....................................................
File vdsm/API.py
Line 1126:             stats['momStatus'] = self._cif.mom.getStatus()
Line 1127:             stats.update(self._cif.mom.getKsmStats())
Line 1128:         else:
Line 1129:             stats['momStatus'] = 'disabled'
Line 1130:             stats['ksmState'] = self._cif.running()
Yes, it has "import ksm", wich brings running().
Anyway, changing to ksm.running()
Thank you for your review.
Line 1131:             stats['ksmPages'] = self._cif.npages()
Line 1132:             stats['ksmCpu'] = self._cif.ksmMonitor.cpuUsage
Line 1133:             stats['memShared'] = self._memShared() / Mbytes
Line 1134:

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/287/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/253/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/253/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/287/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 4: Verified; Looks good to me, but someone else must approve

Test:

# vdsClient -s 0 getVdsStats | grep ksmState
ksmState = True

# cat /sys/kernel/mm/ksm/run
1

# echo 0 > /sys/kernel/mm/ksm/run
# vdsClient -s 0 getVdsStats | grep ksmState
ksmState = False

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

Doron Fediuck has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Online check ksmState and ksmPages.
......................................................................

Patch Set 4: Looks good to me, approved

/me is trusting Douglas's verification.

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Online check ksmState and ksmPages.
......................................................................

Online check ksmState and ksmPages.

Currently ksmState and ksmPages is updated only when adjust()
is called (vm._startUnderlyingVm() and libvirt.releaseVm()).
Since ksmtuned can turn on/off ksm any time, vdsm will report
inaccurate information until adjust() be called.
This patch changes ksmState and ksmPages update to every API
call, reflecting always the accurate information.

Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Signed-off-by: Amador Pahim 
---
M vdsm/API.py
M vdsm/ksm.py
2 files changed, 6 insertions(+), 12 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
  Doron Fediuck: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9510
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Doron Fediuck 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Laszlo Hornyak 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Xu He Jie 
Gerrit-Reviewer: oVirt Jenkins CI Server