3:04 a.m.
Vinzenz Feenstra has uploaded a new change for review.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
vdsm: Delay desktop lock until we are sure it was a disconnect
This is a hack to mitigate the issue of spice-gtk not respecting the
configured secure channels. Spice-gtk is always connecting first to
a non-secure channel and the server tells the client then to connect
to a secure channel. However as a result of this we're getting events
of false positive disconnects and we need to ensure that we're really
having a disconnected client
This timer is supposed to delay the call to lock the desktop of the
guest. And only lock it, if it there was no new connect.
This is detected by the clientIp being set or not.
Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/13798/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index e327207..1f8fbe4 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -49,6 +49,8 @@
CONSOLE_DEVICES = 'console'
SMARTCARD_DEVICES = 'smartcard'
+_DESKTOP_LOCK_TIMEOUT = 2
+
"""
A module containing classes needed for VM communication.
"""
@@ -822,9 +824,24 @@
if clientIp:
self.conf['clientIp'] = clientIp
+ def _timedDesktopLock(self):
+ if not self.conf.get('clientIp', ''):
+ self.guestAgent.desktopLock()
+
def onDisconnect(self, detail=None):
- self.guestAgent.desktopLock()
self.conf['clientIp'] = ''
+ # This is a hack to mitigate the issue of spice-gtk not respecting the
+ # configured secure channels. Spice-gtk is always connecting first to
+ # a non-secure channel and the server tells the client then to connect
+ # to a secure channel. However as a result of this we're getting events
+ # of false positive disconnects and we need to ensure that we're really
+ # having a disconnected client
+ # This timer is supposed to delay the call to lock the desktop of the
+ # guest. And only lock it, if it there was no new connect.
+ # This is detected by the clientIp being set or not.
+ self._desktopLockTimer = threading.Timer(_DESKTOP_LOCK_TIMEOUT,
+ self._timedDesktopLock)
+ self._desktopLockTimer.start()
def _rtcUpdate(self, timeOffset):
self.log.debug('new rtc offset %s', timeOffset)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
5:19 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
vdsm: Delay desktop lock until we are sure it was a disconnect
This is a hack to mitigate the issue of spice-gtk not respecting the
configured secure channels [1]. Spice-gtk is always connecting first to
a non-secure channel and the server tells the client then to connect
to a secure channel. However as a result of this we're getting events
of false positive disconnects and we need to ensure that we're really
having a disconnected client
This timer is supposed to delay the call to lock the desktop of the
guest. And only lock it, if it there was no new connect.
This is detected by the clientIp being set or not.
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=879352
Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Bug-Url: https://bugzilla.redhat.com/905930
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
Vinzenz Feenstra: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:19 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 4: Looks good to me, approved
hopefully this ugliness can be reverted soon.
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:17 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2049/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1992/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:15 a.m.
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:14 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2049/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:14 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1992/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:12 a.m.
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 3: (3 inline comments)
....................................................
Commit Message
Line 8:
Line 9: This is a hack to mitigate the issue of spice-gtk not respecting the
Line 10: configured secure channels. Spice-gtk is always connecting first to
Line 11: a non-secure channel and the server tells the client then to connect
Line 12: to a secure channel. However as a result of this we're getting events
Well the problem is that we cannot enforce that all users will have that fixed version.
And I hate to have to tell an admin that he has to upgrade a few thousand clients of
different types of systems to a specific version of spice-gtk. If I would be that admin I
would seriously start thinking about moving on to a different solution...
I will add that link
Line 13: of false positive disconnects and we need to ensure that we're really
Line 14: having a disconnected client
Line 15: This timer is supposed to delay the call to lock the desktop of the
Line 16: guest. And only lock it, if it there was no new connect.
....................................................
File vdsm/vm.py
Line 48: WATCHDOG_DEVICES = 'watchdog'
Line 49: CONSOLE_DEVICES = 'console'
Line 50: SMARTCARD_DEVICES = 'smartcard'
Line 51:
Line 52: _DESKTOP_LOCK_TIMEOUT = 2
Done
Line 53:
Line 54: """
Line 55: A module containing classes needed for VM communication.
Line 56: """
Line 829: self.guestAgent.desktopLock()
Line 830:
Line 831: def onDisconnect(self, detail=None):
Line 832: self.conf['clientIp'] = ''
Line 833: # This is a hack to mitigate the issue of spice-gtk not respecting the
I wish there'd be a better way :( I am out of ideas.
Line 834: # configured secure channels. Spice-gtk is always connecting first to
Line 835: # a non-secure channel and the server tells the client then to connect
Line 836: # to a secure channel. However as a result of this we're getting
events
Line 837: # of false positive disconnects and we need to ensure that we're
really
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:43 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
Commit Message
Line 8:
Line 9: This is a hack to mitigate the issue of spice-gtk not respecting the
Line 10: configured secure channels. Spice-gtk is always connecting first to
Line 11: a non-secure channel and the server tells the client then to connect
Line 12: to a secure channel. However as a result of this we're getting events
could you add a link to the spice-gtk bug? Shouldn't we just wait for it to be solved
there? How long would it take?
Line 13: of false positive disconnects and we need to ensure that we're really
Line 14: having a disconnected client
Line 15: This timer is supposed to delay the call to lock the desktop of the
Line 16: guest. And only lock it, if it there was no new connect.
....................................................
File vdsm/vm.py
Line 48: WATCHDOG_DEVICES = 'watchdog'
Line 49: CONSOLE_DEVICES = 'console'
Line 50: SMARTCARD_DEVICES = 'smartcard'
Line 51:
Line 52: _DESKTOP_LOCK_TIMEOUT = 2
please put this piece of ugliness into the only function that uses it.
Line 53:
Line 54: """
Line 55: A module containing classes needed for VM communication.
Line 56: """
Line 829: self.guestAgent.desktopLock()
Line 830:
Line 831: def onDisconnect(self, detail=None):
Line 832: self.conf['clientIp'] = ''
Line 833: # This is a hack to mitigate the issue of spice-gtk not respecting the
I like your spirit, showing how much you hate this attempt to solve a race with a
sleep().
Line 834: # configured secure channels. Spice-gtk is always connecting first to
Line 835: # a non-secure channel and the server tells the client then to connect
Line 836: # to a secure channel. However as a result of this we're getting
events
Line 837: # of false positive disconnects and we need to ensure that we're
really
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:04 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1906/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:58 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:57 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1964/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1913/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:55 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1913/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:54 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1964/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:53 a.m.
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vm.py
Line 840: # guest. And only lock it, if it there was no new connect.
Line 841: # This is detected by the clientIp being set or not.
Line 842: self._desktopLockTimer = threading.Timer(_DESKTOP_LOCK_TIMEOUT,
Line 843: self._timedDesktopLock)
Line 844: self._desktopLockTimer.start()
Well invalidation with the timer would create much more problems and over complicate it.
However I noticed that I am still remembering the timer object.
I have changed that. We don't mind multiple calls on desktop lock, however we would
mind desktopLock to be called when a FP happened.
Line 845:
Line 846: def _rtcUpdate(self, timeOffset):
Line 847: self.log.debug('new rtc offset %s', timeOffset)
Line 848: self.conf['timeOffset'] = timeOffset
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:20 a.m.
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:18 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vm.py
Line 840: # guest. And only lock it, if it there was no new connect.
Line 841: # This is detected by the clientIp being set or not.
Line 842: self._desktopLockTimer = threading.Timer(_DESKTOP_LOCK_TIMEOUT,
Line 843: self._timedDesktopLock)
Line 844: self._desktopLockTimer.start()
where is the onConnect invalidation of this timer?
Line 845:
Line 846: def _rtcUpdate(self, timeOffset):
Line 847: self.log.debug('new rtc offset %s', timeOffset)
Line 848: self.conf['timeOffset'] = timeOffset
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:08 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1958/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1907/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:04 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1957/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:05 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1958/ (2/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:05 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Delay desktop lock until we are sure it was a disconnect
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1907/ (1/2)
--
To view, visit http://gerrit.ovirt.org/13798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af5cf868dc9caaa07134b2b296d985f06cf15f2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4064
days inactive
4070
days old
vdsm-patches@lists.fedorahosted.org
20 comments
5 participants
participants (5)
-
Dan Kenigsberg -
Jenkins CI RO -
michal.skrivanek＠redhat.com -
peet＠redhat.com -
Vinzenz Feenstra