From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: graphics: add from_xml_tree
......................................................................
Patch Set 37:
(2 comments)
minor comment, but generally you have my blessing.
https://gerrit.ovirt.org/#/c/73261/37/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:
PS37, Line 178: self.specParams['displayNetwork'])
this should have been display_network, no need to __getitem__ twice.
PS37, Line 292: if dev.attrib.get('listen') == '0':
: specParams['displayIp'] = '0'
I'm not sure we should prefer this deprecated libvirt attrib. Actually, I think we
should drop these two lines, as we would explode on find_first('listen') if the
new prefereed listen element does not exist.
--
To view, visit
https://gerrit.ovirt.org/73261
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbd97217042e38e03cf4f8cee947287b9d3a945
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes