Change in vdsm[master]: make vdsm/storage/lvm.py PEP8 clean

Hello Mark Wu,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/5818

to review the following change.

Change subject: make vdsm/storage/lvm.py PEP8 clean
......................................................................

make vdsm/storage/lvm.py PEP8 clean

Change-Id: Id7d2093a6307538097ee4c711cecddef8cc77a30
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
---
M Makefile.am
M vdsm/storage/lvm.py
2 files changed, 159 insertions(+), 90 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/5818/1
--
To view, visit http://gerrit.ovirt.org/5818
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7d2093a6307538097ee4c711cecddef8cc77a30
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: make vdsm/storage/lvm.py PEP8 clean
......................................................................


make vdsm/storage/lvm.py PEP8 clean

Change-Id: Id7d2093a6307538097ee4c711cecddef8cc77a30
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
---
M Makefile.am
M vdsm/storage/lvm.py
2 files changed, 153 insertions(+), 89 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/5818
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7d2093a6307538097ee4c711cecddef8cc77a30
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: make vdsm/storage/lvm.py PEP8 clean
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/5818
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d2093a6307538097ee4c711cecddef8cc77a30
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Zhou Zheng Sheng has posted comments on this change.

Change subject: make vdsm/storage/lvm.py PEP8 clean
......................................................................


Patch Set 3: Verified; Looks good to me, but someone else must approve

Run through ./autobuild.sh. pydiff reports no changes in code logic.

Style looks OK.

--
To view, visit http://gerrit.ovirt.org/5818
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d2093a6307538097ee4c711cecddef8cc77a30
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Zhou Zheng Sheng has posted comments on this change.

Change subject: make vdsm/storage/lvm.py PEP8 clean
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

I will fix them in the next patch set.

....................................................
File vdsm/storage/lvm.py
Line 177: 
Move the blank lines to above the comments

Line 725: 
Move blank lines to above the comments

Line 798: 
Move blank lines to above the comments

--
To view, visit http://gerrit.ovirt.org/5818
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d2093a6307538097ee4c711cecddef8cc77a30
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;