Change in vdsm[master]: api: domainDict is optional in connectStoragePool

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................

api: domainDict is optional in connectStoragePool

This patch fixes a mismatch between the schema and the actual
connectStoragePool implementation.

Change-Id: I05b4f5073a33b2479404298ddafd4802e949e8f4
Signed-off-by: Federico Simoncelli 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/24089/1

diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 6d8c333..71ee38f 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -4250,7 +4250,9 @@
 #
 # @masterVersion:  The Storage Domain version of the master domain
 #
-# @domainDict:     The Storage Domain statuses (added in cluster level 3.4)
+# @domainDict:     #optional The Storage Domain statuses (added in cluster
+#                  level 3.4). If this argument is present the Storage Pool
+#                  will use the memory backend (no metadata).
 #
 # Since: 4.10.0
 #
@@ -4259,7 +4261,7 @@
 {'command': {'class': 'StoragePool', 'name': 'connect'},
  'data': {'storagepoolID': 'UUID', 'hostID': 'int', 'scsiKey': 'str',
           'masterSdUUID': 'UUID', 'masterVersion': 'int',
-          'domainDict': 'StorageDomainStatusMap'}}
+          '*domainDict': 'StorageDomainStatusMap'}}

##
 # @ConnectStorageServerStatus:

Ayal Baron has posted comments on this change.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................

Patch Set 1: Code-Review+1

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/24089/1/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:

Line 4251: # @masterVersion:  The Storage Domain version of the master domain
Line 4252: #
Line 4253: # @domainDict:     #optional The Storage Domain statuses (added in cluster
Line 4254: #                  level 3.4). If this argument is present the Storage Pool
Line 4255: #                  will use the memory backend (no metadata).
This is name is consistent with the schema (see reconstractMaster), but does not match the code (domainsMap). I suggest that we get this in now, and unify the names used in the schema and the code later.
Line 4256: #
Line 4257: # Since: 4.10.0
Line 4258: #
Line 4259: # Notes:  Only one Storage pool may be connected at a time

Sergey Gotliv has posted comments on this change.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................

Patch Set 1: Code-Review+1

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................

Patch Set 1: Verified+1

Nothing much to verify. The rpm builds successfully.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................

api: domainDict is optional in connectStoragePool

This patch fixes a mismatch between the schema and the actual
connectStoragePool implementation.

Change-Id: I05b4f5073a33b2479404298ddafd4802e949e8f4
Signed-off-by: Federico Simoncelli 
Reviewed-on: http://gerrit.ovirt.org/24089
Reviewed-by: Ayal Baron 
Reviewed-by: Nir Soffer 
Reviewed-by: Sergey Gotliv 
Reviewed-by: Dan Kenigsberg 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Verified
  Sergey Gotliv: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: api: domainDict is optional in connectStoragePool
......................................................................

Patch Set 1: Code-Review+2