From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: deeper libvirtconnection test
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/67494/2/tests/libvirtconnectionTests.py
File tests/libvirtconnectionTests.py:
Line 123: conn = libvirtconnection.get()
Line 124: self.assertRaises(libvirt.libvirtError,
Line 125: conn.getLibVersion)
Line 126: finally:
Line 127: libvirtconnection._clear()
we need to test that
* we attempt to commit suicide if libvirt dies
* target receives events
* ? the underlying libvirt is called ?
--
To view, visit
https://gerrit.ovirt.org/67494
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca111caa25fdc568b7f188a503c8faa83848f4c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes