Adam Litke has uploaded a new change for review.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
XXX: Insert sleep when creating block SD
Change-Id: I10ed63d747f1353da824af8ec56ac8a6f66d666b Signed-off-by: Adam Litke alitke@redhat.com --- M vdsm/storage/blockSD.py 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/43553/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 0b8bdc7..0d5e403 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -896,6 +896,10 @@ # Create VMS file system _createVMSfs(os.path.join("/dev", vgName, MASTERLV))
+ # XXX: When running an iSCSI server and initiator on the same host we + # need to wait a bit for IO to settle before deactivating LVs + import time + time.sleep(10) lvm.deactivateLVs(vgName, MASTERLV)
path = lvm.lvPath(vgName, sd.METADATA)
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43553/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py:
Line 898: Line 899: # XXX: When running an iSCSI server and initiator on the same host we Line 900: # need to wait a bit for IO to settle before deactivating LVs Line 901: import time Line 902: time.sleep(10) This is not a real solution. Maybe you want to use sync() instead? Line 903: lvm.deactivateLVs(vgName, MASTERLV) Line 904: Line 905: path = lvm.lvPath(vgName, sd.METADATA) Line 906:
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Adam Litke has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 8: Code-Review-2
Jenkins CI RO has abandoned this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
gerrit-hooks has posted comments on this change.
Change subject: XXX: Insert sleep when creating block SD ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org
-
alitke＠redhat.com -
automation＠ovirt.org -
Jenkins CI RO -
Nir Soffer