Change in vdsm[master]: [WIP] Fix mounts parsing

Saggi Mizrahi has uploaded a new change for review.

Change subject: [WIP] Fix mounts parsing
......................................................................

[WIP] Fix mounts parsing

Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
---
M vdsm/storage/mount.py
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/3261/1
--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Fix mounts parsing
......................................................................

Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 7: [WIP] Fix mounts parsing
could you explain here where when and why does this funny line appears in /proc/mounts?

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Fix mounts parsing
......................................................................

Patch Set 7: I would prefer that you didn't submit this

could you explain here where when and why does this funny line appears in /proc/mounts?

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Fix mounts parsing
......................................................................

Patch Set 15: I would prefer that you didn't submit this

what's with these frequent rebases? Is there any news here?

I know that it is easier to push the whole branch after rebase, but if there's nothing new, I'd appreciate some silence.

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Fix mounts parsing
......................................................................

Patch Set 15: (1 inline comment)

....................................................
File vdsm/storage/mount.py
Line 54:             for suffix in ("\040(deleted)",):
What does this suffix signifies? Is there a sane way to obtain the state of this mountpoint? Current could would result in error if you are mounting something on a directory called '/mnt/bla (deleted)'

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: mount.py: handle (deleted) mount points

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: mount.py: handle (deleted) mount points
......................................................................

Patch Set 16:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/277/ (2/2)

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: mount.py: handle (deleted) mount points

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: mount.py: handle (deleted) mount points
......................................................................

Patch Set 16:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/311/ (1/2)

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: mount.py: handle (deleted) mount points

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: mount.py: handle (deleted) mount points
......................................................................

Patch Set 16:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/277/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/311/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: mount.py: handle (deleted) mount points

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: mount.py: handle (deleted) mount points
......................................................................

Patch Set 16: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: mount.py: handle (deleted) mount points

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: mount.py: handle (deleted) mount points
......................................................................

Patch Set 16: Verified

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: mount.py: handle (deleted) mount points

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: mount.py: handle (deleted) mount points
......................................................................

Patch Set 16:

Thanks!

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: mount.py: handle (deleted) mount points

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: mount.py: handle (deleted) mount points
......................................................................

mount.py: handle (deleted) mount points

If an NFS mount is removed from the server, client side kernel appends
" (deleted)" to it specification. It comes from fs/dcache.c's d_path()
function:

Convert a dentry into an ASCII path name. If the entry has been deleted
  the string " (deleted)" is appended. Note that this is ambiguous.

In this patch we assume that every mount specification ending with this
string is indeed a deleted one, and not a funky nfs server provided by
an evil admin that hates Linux.

Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Bug-Url: http://bugzilla.redhat.com/807351
Signed-off-by: Saggi Mizrahi 
Signed-off-by: Dan Kenigsberg 
---
M vdsm/storage/mount.py
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Haim Ateya: Verified
  Federico Simoncelli: Looks good to me, approved
  Dan Kenigsberg:

--
To view, visit http://gerrit.ovirt.org/3261
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fdeda5f2900d818912ef5a939b60687462d5344
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Paikov 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Haim Ateya 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: oVirt Jenkins CI Server